Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: smoother feedback list dark mode (fixes #4454) #4461

Merged
merged 7 commits into from
Sep 24, 2024
Merged

all: smoother feedback list dark mode (fixes #4454) #4461

merged 7 commits into from
Sep 24, 2024

Conversation

Kuljeet1998
Copy link
Contributor

Fixes: #4454

@Kuljeet1998 Kuljeet1998 linked an issue Sep 23, 2024 that may be closed by this pull request
feedback cards incompatible w dark mode #4454
Closed
@Kuljeet1998
Copy link
Contributor Author

@deeppp15 @Okuro3499 could you please check if its working in light mode? On the preview, the changes are being reflected, but on my phone its not. Could you guys please test and let me know.

@Okuro3499
Copy link
Collaborator

@Kuljeet1998 in darkmode it works but in light mode it's still dark
Screenshot_20240923_215001

@Okuro3499
Copy link
Collaborator

@Kuljeet1998 in the master branch even before we do any changes the card seem to have a grey background I haven't been able to figure out where it's being set but checking this could be the first step

@deeppp15
Copy link
Member

Hi @Kuljeet1998

In my phone the light mode seems fine but the problem is in darkmode.

0fd79f65-a88b-4b0f-8f26-47c42dce7ebe

08e5bbd7-75b2-4c7e-a917-d94779bd6203

@deeppp15 deeppp15 self-requested a review September 24, 2024 17:36
@Kuljeet1998 Kuljeet1998 marked this pull request as ready for review September 24, 2024 17:57
@Kuljeet1998
Copy link
Contributor Author

Working fine now @deeppp15 @Okuro3499
image
image

@dogi dogi changed the title smoother dark mode: feedback list (fixes: #4454) all: smoother feedback list dark mode (fixes #4454) Sep 24, 2024
@dogi dogi merged commit 904d4a4 into master Sep 24, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 4454-feedback-cards-incompatible-w-dark-mode branch October 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogi dogi dogi approved these changes

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@deeppp15 deeppp15 deeppp15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feedback cards incompatible w dark mode
4 participants
@Kuljeet1998 @Okuro3499 @deeppp15 @dogi