OSHMEM/MCA/SPML/UCX: v1.5 implement put_signal and put_signal_nbi #13568
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roie Danino <[email protected]>
roiedanino
changed the title
Contributor
Author
janjust
previously approved these changes
Dec 16, 2025
gleon99
previously approved these changes
Dec 18, 2025
| return res; | ||
| } | ||
|
|
||
| return mca_spml_ucx_signal_common(ctx, sig_addr, signal, sig_op, dst); |
Contributor
There was a problem hiding this comment.
Don't we need a fence here?
Contributor
Author
There was a problem hiding this comment.
Not according to the v1.5 spec
oshmem/mca/spml/ucx/spml_ucx.c
Outdated
|
|
||
| /* This routine is not implemented */ | ||
| static inline int mca_spml_ucx_signal_common(shmem_ctx_t ctx, | ||
| uint64_t *sig_addr, |
Signed-off-by: Roie Danino <[email protected]>
janjust
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements
mca_spml_ucx_put_signalandmca_spml_ucx_put_signal_nbfor OpenSHMEM signaling operations with UCX backend.Why
The put_signal operations are part of the OpenSHMEM 1.5 specification and were previously unimplemented (returning OSHMEM_ERR_NOT_IMPLEMENTED).