Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS file #351

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Create CODEOWNERS file #351

wants to merge 1 commit into from

Conversation

SWilson4
Copy link
Member

@SWilson4 SWilson4 commented Feb 12, 2025

Fixes #350.

This is my initial stab at defining CODEOWNERS for the purposes of automatic review requests. It includes

I haven't included all demos "maintainers" (per the README), only those who currently have write permissions on an OQS repo.

The file is currently invalid because @pi-314159 and @ajbozarth don't have write permissions on the repository. As both have made sizeable contributions to this repo, I propose that we give them write permissions, i.e., elevate them to "codeowner" status for oqs-demos. If there are no objections, I'll create a PR on the tsc repo to add them to the appropriate team.

Signed-off-by: Spencer Wilson <[email protected]>
@SWilson4 SWilson4 marked this pull request as draft February 12, 2025 16:41
@SWilson4
Copy link
Member Author

Leaving as draft until the CODEOWNERS file is validated by tsc config.yaml changes.

@baentsch
Copy link
Member

This #352 (comment)

I would not personally have the bandwidth the help until March

aligns with the heads-up by @ajbozarth late last year that his focus has changed away from OQS. I thus don't consider it prudent to assign this status to him as there's no guarantee he can spare enough time to thoroughly look at things.

Asking @pi-314159 and @bhess in turn: Can you commit sufficient cycles on short notice to help "shepard through" PRs (check for potential and actual problems, give debugging support to contributors, etc) if auto-tagged "reviewer"? Anyone else in @open-quantum-safe/oqs-committers willing to serve in this role?

(Or ?) Maybe worth while creating a new group "open-quantum-safe/reviewers"? I'd be willing to be a member -- maybe you too, @SWilson4 @praveksharma ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CODEOWNERS file
3 participants