Conversation
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
arjo129
reviewed
Jun 22, 2026
arjo129
left a comment
Member
There was a problem hiding this comment.
I tested this feature and it works as expected.
| @@ -0,0 +1 @@ | |||
| ../../../assets/demo_maps/office.site.json No newline at end of file | |||
Member
There was a problem hiding this comment.
knit: While symlinks work fine on macOS/Linux they could be mildly problematic for windows developers. See: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows
Windows needs to be put into "developer mode" for symlinks to work correctly. Im suspecting that our CI already is configured in developer mode and hence does not catch this.
FWIW this comment might be slightly outdated in 2026 as Ive not touched windows for a while.
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing with the site editor to think through the interior design of my upcoming home, I found that the uniform height of walls and doors creates a distorted impression of what a building really looks like.
This PR adds the ability to adjust the height of the tops and bottoms of walls and doors. The office demo site has been updated to take advantage of this feature:
To adjust the top/bottom height, select the wall or door that you want to modify and then find the height widget in the inspection panel:
You can choose between
ratioorfixed:ratio- A ratio (recommended values from 0.0 to 1.0) of how high up to the next level. A value of 1.0 means it extends all the way to the elevation of the next level, if one exists.DEFAULT_LEVEL_HEIGHTwhich is 3m.fixed- A fixed value in meters.