Skip to content

Customizable heights for walls and doors#430

Open
mxgrey wants to merge 6 commits into
mainfrom
heights
Open

Customizable heights for walls and doors#430
mxgrey wants to merge 6 commits into
mainfrom
heights

Conversation

@mxgrey

@mxgrey mxgrey commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

While playing with the site editor to think through the interior design of my upcoming home, I found that the uniform height of walls and doors creates a distorted impression of what a building really looks like.

This PR adds the ability to adjust the height of the tops and bottoms of walls and doors. The office demo site has been updated to take advantage of this feature:

Screenshot from 2026-06-20 19-17-17

To adjust the top/bottom height, select the wall or door that you want to modify and then find the height widget in the inspection panel:

Screenshot from 2026-06-20 19-21-59

You can choose between ratio or fixed:

  • ratio - A ratio (recommended values from 0.0 to 1.0) of how high up to the next level. A value of 1.0 means it extends all the way to the elevation of the next level, if one exists.
    • If no level exists above the current one, then we fall back to DEFAULT_LEVEL_HEIGHT which is 3m.
    • If the elevation of the next level up is less than 2.0m above the current one, we interpret that as a mistake and fall back on 3m.
    • If the elevation of the next level is changed, walls and doors with this setting will automatically change as well.
  • fixed - A fixed value in meters.

mxgrey added 3 commits June 20, 2026 16:35
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
mxgrey added 2 commits June 20, 2026 19:28
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>

@arjo129 arjo129 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this feature and it works as expected.

@@ -0,0 +1 @@
../../../assets/demo_maps/office.site.json No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knit: While symlinks work fine on macOS/Linux they could be mildly problematic for windows developers. See: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows

Windows needs to be put into "developer mode" for symlinks to work correctly. Im suspecting that our CI already is configured in developer mode and hence does not catch this.

FWIW this comment might be slightly outdated in 2026 as Ive not touched windows for a while.

Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants