Demo: Offer TLS settings for remote connections#338
Merged
tigrannajaryan merged 10 commits intoMay 26, 2025
Merged
Conversation
michel-laterman
force-pushed
the
feat/tls-connection-settings
branch
from
49be2fd to
b6256c4
Compare
Offer example code for setting the TLS min version through the proposed new TLSConnectionSettings. Also add a -request-connection-settings flag to the example agent to demo the agent-initiated CA trust flow.
michel-laterman
force-pushed
the
feat/tls-connection-settings
branch
from
2865b33 to
7e672b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 80.20% 80.40% +0.20%
==========================================
Files 26 26
Lines 2495 2495
==========================================
+ Hits 2001 2006 +5
+ Misses 383 379 -4
+ Partials 111 110 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michel-laterman
force-pushed
the
feat/tls-connection-settings
branch
from
6a47c0e to
fc7ef55
Compare
tigrannajaryan
approved these changes
May 9, 2025
Member
|
Please update the spec submodule to ffb236cf005642aeb96e5448b005d69d6de1a75a |
Member
|
I will keep this open for a while in case other @open-telemetry/opamp-go-approvers want to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to go along with open-telemetry/opamp-spec#205
The example agent has been expanded with the ability to accept various TLS settings for the OpAMP connection.
In order to demo this; this start both the example agent and server, then view the agent in the server UI. There is a new OpAMP connections settings area with the ability to specify and send the TLS min version.