[processor/redaction] Introduce blocked_key_patterns parameter
#37664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
7c82c57 to
b3a192a
Compare
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
b3a192a to
71decca
Compare
mx-psi
reviewed
Feb 24, 2025
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
be2df19 to
b8eed15
Compare
odubajDT
commented
Feb 25, 2025
odubajDT
changed the title
blocked_key_patterns and support hashing instead of masking values via hash_function parameterblocked_key_patterns parameter
mx-psi
approved these changes
Feb 25, 2025
| @@ -43,6 +45,11 @@ func newRedaction(ctx context.Context, config *Config, logger *zap.Logger) (*red | |||
| // TODO: Placeholder for an error metric in the next PR | |||
| return nil, fmt.Errorf("failed to process block list: %w", err) | |||
| } | |||
| blockKeysRegexList, err := makeRegexList(ctx, config.BlockedKeyPatterns) | |||
| if err != nil { | |||
| // TODO: Placeholder for an error metric in the next PR | |||
There was a problem hiding this comment.
Can we have an issue for any TODO in the code?
There was a problem hiding this comment.
this TODO comment was copied from a block right above this. I have zero context what needs to be done here, but added it also here, since it's present in every block that is creating regex list
There was a problem hiding this comment.
Okay, fair, feel free to file an issue to investigate the mysterious TODOs then, but no need for it to block merging this PR :)
…shing instead of masking values via 'hash_function' parameter Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
redaction-blocked-patterns
branch
from
2e982da to
28c2244
Compare
atoulme
pushed a commit
that referenced
this pull request
Mar 4, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - added `hash_function` parameter to support hashing the values (or substrings of values) instead of masking them with a fixed string. By default fixed string masking is performed <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #35830 #### Depends on #37664 --------- Signed-off-by: odubajDT <[email protected]> Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
blocked_key_patternsparameter to mask values of attributes, which keys match at least one of the defined patternsLink to tracking issue
Fixes #35830
Follow-up
#38161