[extension/sumologicextension] Sanitize version information #37689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version numbers introduced by the new packaging implementation are not supported by the backend when sending collector information. When this new format is recognized clean it up to send a version that is compatible with the backend.
Version numbers introduced by the new packaging implementation are not supported by the backend when sending collector information. When this new format is recognized clean it up to send a version that is compatible with the backend.
Module set contrib-base, Version v0.114.0 Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
github-actions
bot
requested review from
chan-tim-sumo,
echlebek and
rnishtala-sumo
echlebek
approved these changes
Feb 5, 2025
chan-tim-sumo
approved these changes
Feb 10, 2025
rnishtala-sumo
approved these changes
Feb 10, 2025
mx-psi
approved these changes
Feb 11, 2025
|
does this need a changelog? |
|
@amdprophet I think we do need a changelog for this - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry |
rnishtala-sumo
force-pushed
the
build-number-fix
branch
from
1d9a5fd to
b26162f
Compare
|
@mx-psi @amdprophet I went ahead and added a changelog for this. |
rnishtala-sumo
force-pushed
the
build-number-fix
branch
from
b26162f to
52086a9
Compare
MovieStoreGuy
approved these changes
Feb 19, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The format of versions reported by Sumo Logic's distribution of the OpenTelemetry collector recently changed. The new format is not currently supported by the sumologicextension in this repository. This PR adds a new function to sanitize the version before it is used to send data to the Sumo Logic backend service.
Testing
Added unit tests to test variations of possible collector version output. Used in the last two releases of Sumo Logic's distribution of the OpenTelemetry Collector.