[chore] update genqlient to v0.8.0 and fix broken tests #37700
+56
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielp
requested review from
andrzej-stencel,
crobert-1,
TylerHelmuth and
a team
as code owners
internal/tools/go.mod
Outdated
| go 1.22.1 | ||
| go 1.22.5 | ||
|
|
||
| toolchain go1.23.5 |
There was a problem hiding this comment.
Can we remove this line?
There was a problem hiding this comment.
Doesn't look like it. It popped up when running make tidy after I updated the genqlient version to v0.8.0.
I downloaded go 1.22.0 & go 1.22.5 just to see if using tidy with those versions would fix it. There's a dependency being updated that requires at least go1.22.12. Here's the response I get:
$ go1.22.0 mod tidy -compat=1.22.0
go: github.com/gostaticanalysis/[email protected] requires go >= 1.22.9; switching to go1.22.12And workflows fail when not having those values.
There was a problem hiding this comment.
It looks like this is coming from genqlient updating its go directive.
Since this is the only place that needed to be updated for CI/CD to pass, it's okay with me.
crobert-1
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They changed HTTP response handling in v0.8.0 so adjusted the tests to support the changes and updated the corresponding packages. Supersedes #37670
Link to tracking issue
Fixes #37670