[Infra] Create releases as drafts before publish #3587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than rely on `gh release` doing the right thing and to make the code more explicit, create releases as drafts, then edit them to not be a draft to release them. This matches the effective behaviour in open-telemetry/opentelemetry-dotnet. Relates to open-telemetry#3584.
Add clarifying comment.
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
Copilot finished reviewing on behalf of
martincostello
December 4, 2025 15:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the release creation workflow to create GitHub releases as drafts before publishing them, ensuring that all assets are uploaded before the release becomes immutable.
Key Changes:
- Adds
--draftflag to both prerelease and stable release creation commands - Introduces
gh release edit $tag --draft=falsecommand to publish the draft after creation - Adds explanatory comment about why drafts are used (immutable releases cannot have assets added after publish)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3584.
Changes
Rather than rely on
gh releasedoing the right thing and to make the code more explicit, create releases as drafts, then edit them to not be a draft to release them.This matches the effective behaviour in open-telemetry/opentelemetry-dotnet (see open-telemetry/opentelemetry-dotnet#6748).
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)