Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otlp] Fix doc for LogRecord.EventId attributes #5251

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[otlp] Fix doc for LogRecord.EventId attributes #5251

merged 2 commits into from
Jan 25, 2024

Conversation

sprayzcs
Copy link
Contributor

There is an issue in the documentation for enabling the export of the LogRecord.EventId.Id and LogRecord.EventId.Name attributes. The environment variable to enable the export is OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES and not OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_CATEGORY_EVENT_ATTRIBUTES as stated in the docs

see ExperimentalOptions.cs

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@sprayzcs sprayzcs requested a review from a team January 24, 2024 11:15
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sprayzcs (46395ef)
  • ✅ login: CodeBlanch / name: Mikel Blanchard (62dd1a9)

@sprayzcs sprayzcs force-pushed the docs_logrecord_eventid branch from 3badc01 to 46395ef Compare January 24, 2024 11:16
@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Jan 25, 2024
@CodeBlanch CodeBlanch changed the title [docs] Fix doc for LogRecord.EventId attributes [otlp] Fix doc for LogRecord.EventId attributes Jan 25, 2024
@CodeBlanch CodeBlanch merged commit 0fefe37 into open-telemetry:main Jan 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sprayzcs @cijothomas @rajkumar-rangaraj @vishweshbankwar @CodeBlanch