Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared] Refactor logging for configuration extensions #5469

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5466

Changes

  • Removes the static coupling used to bind logging for configuration extensions
  • Hooks up logging for invalid configuration keys in aspnetcore instrumentation

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team March 22, 2024 18:16
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.46%. Comparing base (6250307) to head (85230e0).
Report is 143 commits behind head on main.

❗ Current head 85230e0 differs from pull request most recent head 1cb027b. Consider uploading reports for the commit 1cb027b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5469      +/-   ##
==========================================
+ Coverage   83.38%   85.46%   +2.07%     
==========================================
  Files         297      289       -8     
  Lines       12531    12518      -13     
==========================================
+ Hits        10449    10698     +249     
+ Misses       2082     1820     -262     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.20% <27.27%> (?)
unittests-Instrumentation-Stable 24.24% <27.27%> (?)
unittests-Solution-Experimental 85.47% <88.57%> (?)
unittests-Solution-Stable 85.13% <88.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <100.00%> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 90.32% <100.00%> (-9.68%) ⬇️
...elemetryProtocol/Implementation/SdkLimitOptions.cs 100.00% <100.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 97.34% <100.00%> (+0.98%) ⬆️
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 88.46% <ø> (-0.43%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 78.26% <100.00%> (-5.08%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 88.00% <ø> (-3.18%) ⬇️
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.42% <ø> (+2.98%) ⬆️
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <100.00%> (ø)
...spNetCore/AspNetCoreTraceInstrumentationOptions.cs 100.00% <100.00%> (ø)
... and 8 more

... and 58 files with indirect coverage changes

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 21aeaa7 into open-telemetry:main Mar 26, 2024
49 checks passed
@CodeBlanch CodeBlanch deleted the shared-configuration-extensions-logging branch March 26, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants