Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Move OTEL_TRACES_SAMPLER_* feature changelog from '1.8.0-beta.1' to 'Unreleased' #5482

Conversation

julealgon
Copy link

@julealgon julealgon commented Mar 27, 2024

Fixes #5480

Changes

This PR fixes a minor inconsistency in the OpenTelemetry project's CHANGELOG file that listed the following feature in the incorrect release: the feature was not yet released and was wrongly mentioned as part of the 1.8.0-beta.1 release.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@julealgon julealgon requested a review from a team March 27, 2024 20:23
Copy link

linux-foundation-easycla bot commented Mar 27, 2024

CLA Missing ID CLA Not Signed

@julealgon julealgon marked this pull request as draft March 27, 2024 20:36
@julealgon
Copy link
Author

Converting to draft while I resolve the CLA blocker.

… 'Unreleased'

The feature was added to the codebase _after_ `1.8.0-beta.1` had already been cut. It should be made available in the next release instead, which is why it should be in the "Unreleased" section of the changelog.

This was originally introduced in:
- [sdk-traces] Add support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG (open-telemetry#5448) (76cafe5)
@julealgon julealgon force-pushed the julealgon/issue-5480/moveTraceSamplerChangelog branch from e1d84ed to 0336c59 Compare March 27, 2024 20:40
@CodeBlanch
Copy link
Member

@julealgon Hey sorry @utpilla and I were about to release 1.8.0-rc.1 so we included this on there: #5483

Good catch though thank you for submitting this!

@CodeBlanch CodeBlanch closed this Mar 27, 2024
@julealgon julealgon deleted the julealgon/issue-5480/moveTraceSamplerChangelog branch March 27, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envvar-based sampler configuration capability should not be mentioned as part of 1.8.0-beta.1 changelog
2 participants