-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Change serialization of null protobuf values #6149
Merged
rajkumar-rangaraj
merged 6 commits into
open-telemetry:main
from
matt-hensley:protobuf-empty-value
Feb 25, 2025
Merged
[otlp] Change serialization of null protobuf values #6149
rajkumar-rangaraj
merged 6 commits into
open-telemetry:main
from
matt-hensley:protobuf-empty-value
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@matt-hensley Changes looks good to me, this should solve the issue. Please update the changelog. |
rajkumar-rangaraj
approved these changes
Feb 24, 2025
Co-authored-by: Rajkumar Rangaraj <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6149 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 257 257
Lines 11574 11574
=======================================
Hits 9996 9996
Misses 1578 1578
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.Console
Issues related to OpenTelemetry.Exporter.Console NuGet package
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
pkg:OpenTelemetry.Exporter.Zipkin
Issues related to OpenTelemetry.Exporter.Zipkin NuGet package
pkg:OpenTelemetry
Issues related to OpenTelemetry NuGet package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6138
Changes
The OTLP exporter generated protobuf payloads that Loki cannot consume when attributes contained null values.
PR extends
TagWriter
to includeTryWriteEmptyTag
method. When a null value is encountered,TryWriteEmptyTag
is called in tag writer implementations instead of only returning false.Tag writers for console, OTLP, and Zipkin exporters have new
TryWriteEmptyTag
implementationsMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes