Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP] include status code in failure log #6154

Merged

Conversation

TimothyMothra
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

The current log omits the Status Code, but that's needed to investigate any failures.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@TimothyMothra TimothyMothra requested a review from a team as a code owner February 25, 2025 23:00
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Feb 25, 2025
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajkumar-rangaraj rajkumar-rangaraj merged commit 577337c into open-telemetry:main Feb 28, 2025
35 checks passed
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (7521728) to head (661fa69).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6154      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files         257      257              
  Lines       11559    11556       -3     
==========================================
- Hits         9981     9978       -3     
  Misses       1578     1578              
Files with missing lines Coverage Δ
...mplementation/ExportClient/OtlpGrpcExportClient.cs 66.27% <ø> (-0.39%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 80.82% <100.00%> (-0.52%) ⬇️

@TimothyMothra TimothyMothra deleted the 202502_recordStatusCode branch February 28, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants