[Exporter.Prometheus] - enable analysis #6171
Conversation
github-actions
bot
added
pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore
Kielek
force-pushed
the
analysis-OpenTelemetry.Exporter.Prometheus
branch
3 times, most recently
from
8015a4c to
50187dc
Compare
| @@ -160,6 +160,9 @@ dotnet_diagnostic.RS0041.severity = suggestion | |||
| # CA1515: Disable making types internal for Tests classes. It is required by xunit | |||
| dotnet_diagnostic.CA1515.severity = none | |||
|
|
|||
| # CA2007: Disable Consider calling ConfigureAwait on the awaited task. It is not working with xunit | |||
| dotnet_diagnostic.CA2007.severity = none | |||
There was a problem hiding this comment.
did you intend to disable this for the entire repo or scope it to just the test projects?
There was a problem hiding this comment.
Tests only. It is done automatically by xunit, but CI executes dotnet format without restoring packages so it cannot be injected by xunit package.
| { | ||
| #pragma warning disable CA2000 |
There was a problem hiding this comment.
nit: please include a comment here describing what is being disabled.
| @@ -62,9 +62,11 @@ public static MeterProviderBuilder AddPrometheusExporter( | |||
| }); | |||
| } | |||
|
|
|||
| private static MetricReader BuildPrometheusExporterMetricReader(PrometheusAspNetCoreOptions options) | |||
| private static BaseExportingMetricReader BuildPrometheusExporterMetricReader(PrometheusAspNetCoreOptions options) | |||
There was a problem hiding this comment.
FYI
CA1859 Change return type of method 'BuildPrometheusExporterMetricReader' from 'OpenTelemetry.Metrics.MetricReader' to 'OpenTelemetry.Metrics.BaseExportingMetricReader' for improved performance
Kielek
force-pushed
the
analysis-OpenTelemetry.Exporter.Prometheus
branch
3 times, most recently
from
db4d444 to
cbde98e
Compare
|
@TimothyMothra, I need to rebase, only new changes are in 3038ff0 (there is a instability after switching to the async) and e3e501b EDIT: Comment updates after nexr rebase |
Kielek
force-pushed
the
analysis-OpenTelemetry.Exporter.Prometheus
branch
from
dd19d54 to
3038ff0
Compare
Towards #3958
Changes
[Exporter.Prometheus] - enable analysis
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)