Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.OTLP] Optimize GetHeaders by Spans #6179

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+24 −14
Open

[Exporter.OTLP] Optimize GetHeaders by Spans #6179

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cda3c88
Refactor code to use Span<T> for header parsing, eliminating Split me…
nimanikoo Mar 8, 2025
65e0744
Fix formatting issues in OtlpExporterOptionsExtensions.cs
nimanikoo Mar 9, 2025
e490141
Fixup indents
nimanikoo Mar 9, 2025
511c8cb
Fix SA1513
nimanikoo Mar 9, 2025
496228b
Fix build issues
Kielek Mar 11, 2025
d73cc15
Update src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterO…
nimanikoo Mar 11, 2025
3820974
Merge branch 'main' into main_ImproveMemoryAllocation
Kielek Mar 11, 2025
bb61cd6
Update OtlpExporterOptionsExtensions.cs
nimanikoo Mar 11, 2025
094907a
Merge branch 'main' into main_ImproveMemoryAllocation
Kielek Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptionsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,23 +58,33 @@ public static THeaders GetHeaders<THeaders>(this OtlpExporterOptions options, Ac
{
// According to the specification, URL-encoded headers must be supported.
optionHeaders = Uri.UnescapeDataString(optionHeaders);
ReadOnlySpan<char> headersSpan = optionHeaders.AsSpan();

Array.ForEach(
optionHeaders.Split(','),
(pair) =>
while (!headersSpan.IsEmpty)
{
int commaIndex = headersSpan.IndexOf(',');
ReadOnlySpan<char> pair;
if (commaIndex == -1)
{
// Specify the maximum number of substrings to return to 2
// This treats everything that follows the first `=` in the string as the value to be added for the metadata key
var keyValueData = pair.Split(['='], 2);
if (keyValueData.Length != 2)
{
throw new ArgumentException("Headers provided in an invalid format.");
}
pair = headersSpan;
headersSpan = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
headersSpan = [];
headersSpan = ReadOnlySpan<char>.Empty;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The [] is the recommended way by the analyzers. IDE0300/IDE0301 as I remember?

Copy link
Contributor

@xiang17 xiang17 Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction. I didn't know it also covers Span.

}
else
{
pair = headersSpan.Slice(0, commaIndex);
headersSpan = headersSpan.Slice(commaIndex + 1);
}

var key = keyValueData[0].Trim();
var value = keyValueData[1].Trim();
addHeader(headers, key, value);
});
int equalIndex = pair.IndexOf('=');
if (equalIndex == -1)
{
throw new ArgumentException("Headers provided in an invalid format.");
}

var key = pair.Slice(0, equalIndex).ToString().Trim();
var value = pair.Slice(equalIndex + 1).ToString().Trim();
addHeader(headers, key, value);
}
}

foreach (var header in OtlpExporterOptions.StandardHeaders)
Expand Down
Loading