[Exporter.Prometheus] Refactor Prometheus serializer#7412
Draft
martincostello wants to merge 10 commits into
Draft
[Exporter.Prometheus] Refactor Prometheus serializer#7412martincostello wants to merge 10 commits into
martincostello wants to merge 10 commits into
Conversation
Add skeleton of new implementation.
Implement the logic for the new serializer design and wire into `PrometheusCollectionManager`.
Update the tests to call the new serializer instead of the old one.
Delete the old `PrometheusSerializer` class.
martincostello
commented
Jun 16, 2026
martincostello
commented
Jun 16, 2026
martincostello
commented
Jun 16, 2026
martincostello
commented
Jun 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7412 +/- ##
==========================================
+ Coverage 89.74% 90.26% +0.52%
==========================================
Files 276 279 +3
Lines 14623 15360 +737
==========================================
+ Hits 13123 13865 +742
+ Misses 1500 1495 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Use PascalCase and remove SA1310 suppression. - Make suppression redundant. - Use `///` comments. - Remove redundant comments.
Fix typo in comment.
Add unit tests for missing patch coverage.
Remove dead code identified by Claude when trying to cover code that was identified as having no tests by codecov.io.
Escape Unicode strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5725, #7155 and #7246.
Changes
PrometheusCollectionManager.PrometheusSerializerclass.WIP as I need to run the benchmarks and check for any clean-up.
The idea is that by splitting things out of the giant monolith we have today, text-format specific behaviours are easier to implement in future PRs.
When ready for review this will probably be easiest to review commit-by-commit (add new code, move tests, delete old code).
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)