feat: add export_unsampled option to batch and simple processors#966
Open
agent-adam wants to merge 2 commits intoopen-telemetry:mainfrom
Open
feat: add export_unsampled option to batch and simple processors#966agent-adam wants to merge 2 commits intoopen-telemetry:mainfrom
agent-adam wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Allow users to opt-in to exporting recording-but-unsampled spans by setting `export_unsampled => true` in the processor config. This enables Collector-side tail-based sampling and RED metrics that need full request counts without forcing 100% head sampling. Default is `false`, preserving spec-compliant behaviour. Closes open-telemetry#891 Made-with: Cursor
feat: add export_unsampled option to batch and simple processors
Author
|
Hey @tsloughter would you able to approve workflow so the CI can run ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to opt-in to exporting recording-but-unsampled spans by setting
export_unsampled => truein the processor config. This enables Collector-side tail-based sampling and RED metrics that need full request counts without forcing 100% head sampling.Default is
false, preserving behaviour before this change.Closes #891