Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-operator): remove default resource values #1457

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Starefossen
Copy link
Contributor

@Starefossen Starefossen commented Dec 9, 2024

Having default values makes it impossible to remove the CPU limits since the default values will always be merged in with anything set by the user. Setting CPU limits are considered an anti pattern ref. https://komodor.com/learn/kubernetes-cpu-limits-throttling/

@Starefossen Starefossen requested review from Allex1 and a team as code owners December 9, 2024 13:06
@Starefossen Starefossen changed the title Remove CPU limits from opentelementry-operator contianers fix(opentelemetry-operator): remove CPU limit from contianers Dec 9, 2024
@TylerHelmuth
Copy link
Member

@Starefossen if you're not using this chart as a subchart you can do:

resources:
  limits:
    cpu: null
    memory: 512Mi

But we can follow the same pattern/reasoning as #745

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 26, 2024
@Starefossen Starefossen changed the title fix(opentelemetry-operator): remove CPU limit from contianers fix(opentelemetry-operator): remove default resource values Dec 30, 2024
@github-actions github-actions bot removed the Stale label Dec 31, 2024
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Starefossen
Copy link
Contributor Author

@Starefossen please include an entry in UPGRADING.md like main/charts/opentelemetry-collector/UPGRADING.md#0531-to-0540

Done

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Starefossen lets also add a warning in NOTES.txt like the collector chart:

{{- if not .Values.resources }}
[WARNING] No resource limits or requests were set. Consider setter resource requests and limits for your collector(s) via the `resources` field.
{{ end }}

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@Starefossen
Copy link
Contributor Author

@TylerHelmuth for some reason I don't get notification for the change requests, I have added the notes.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a make generate-examples CHARTS=opentelemetry-operator but otherwise looks good.

@github-actions github-actions bot removed the Stale label Jan 23, 2025
@Allex1
Copy link
Contributor

Allex1 commented Feb 5, 2025

@Starefossen pls follow instructions HERE so we can merge this.
Thanks for your contribution!

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also use the {{ .Values.resources.limits.cpu | default 100m }} to make this a non-breaking change, but idk if that's worthwhile

@TylerHelmuth
Copy link
Member

we could also use the {{ .Values.resources.limits.cpu | default 100m }} to make this a non-breaking change, but idk if that's worthwhile

I think not, since that would make it impossible to have unbounded CPU, is a goal of some installations.

@TylerHelmuth TylerHelmuth merged commit 640de71 into open-telemetry:main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants