Merged
Conversation
breedx-splk
approved these changes
Feb 3, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Referencing the new workflow is the follow-up work then right?
Member
Author
add reference in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/.github/repository-settings.md? yeah, I added that in this PR now (and added the required check in the settings) |
Member
Author
nope, I got the name wrong, I think I need to merge this PR first, then I can add the new check as required in the rule set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This didn't work: #13164
Trying a more conventional setup.
(OSSF scorecard is supposed to look for a successful run of this and then not warn on binary gradle wrappers)
After merging, I'll update the required status checks.