-
Notifications
You must be signed in to change notification settings - Fork 685
gRPC Instrumentation - Support of metrics, messages as span events, conformity to official grpc.ClientInterceptor and bug fixes #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r and raised exception
… metric attributes
…rib into grpc_dev
… of metrics, tracing of messages and changed API to officical grpc.ClientInterceptor API
Please fix conflicts |
It's a lot to review all of these changes at once. Please split the PR into multiple PRs - one for each fix and a new enhancement. It's easier for reviewers that way. |
@CoLa5 Please fix the conflicts and split the PR into smaller ones, ideally one of each change for faster reviews. |
Requested (#1583) |
Hey @CoLa5 is this feature merged and available in stable release? |
Description
Major Redesign of gRPC Instrumentation, including:
New Feature
OpenTelemetryClientInterceptor
-interface to officialgrpc.ClientInterceptor
-interface (Conformity of client intereptor(s) with the officialgrpc.*ClientInterceptor
-interfaces #1583)Bug Fixes
code()
anddetails()
(opentelemetry-instrumentation-grpc - code()/details()-bug in ServicerContext #855 ) (bugfix(opentelemetry-instrumentation-grpc): Add code() and details() to ServicerContext #1578)abort()
,cancel()
,set_code()
/set_details()
,raise Exception()
abort()
,cancel()
,set_code()
/set_details()
,raise Exception()
grpc.Call
,grpc.Future
,grpc.RpcError
andIterator
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-instrumentation-grpc
runs adaptedinstrumentation/opentelemetry-instrumentation-grpc/tests/test_client_interceptor.py
andinstrumentation/opentelemetry-instrumentation-grpc/tests/test_server_interceptor.py
which test metrics, creation of span events and conformity of interfaces on client-sideDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.