adds NoOpTracerProvider test case for falcon instrumentation #3382
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codeboten , @srikanthccv could you please take a look to review this PR. Thanks. |
kayhern
force-pushed
the
test/nooptracer-tests-for-falcon
branch
from
2868de7 to
1a74060
Compare
|
Hello @xrmx . Could you please take a look at the PR and review it. |
lzchen
approved these changes
Apr 23, 2025
|
hello @lzchen ill rebase and push the changes asap. |
brianwarner
force-pushed
the
test/nooptracer-tests-for-falcon
branch
from
1a74060 to
25e2cf8
Compare
|
@lzchen. Can you please merge the branch.. |
|
@codeboten , @lzchen .Can this be merged or another rebase is needed? |
|
@shwejanraj as github interface says you have to merge main or rebase for us to merge |
emdneto
approved these changes
Apr 28, 2025
Signed-off-by: Shwejan Raj, Bhupathi <[email protected]> Signed-off-by: Bhupathi Shwejan Raj <[email protected]>
kayhern
force-pushed
the
test/nooptracer-tests-for-falcon
branch
from
25e2cf8 to
e00825c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds NoOpTracerProvider test cases for falcon instrumentation.
Fixes #983
How Has This Been Tested?
tox -e test-instrumentation-botocore
pytest instrumentation/opentelemetry-instrumentation-falcon/tests
Does This PR Require a Core Repo Change?