Chore: Drop support for Python 3.8 #3399

jomcgi · 2025-04-01T09:31:36Z

Description

Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support will end @ 2024-04-07.

Changes:

Removed all 3.8 references, updated basline refs to 3.9
Removed 3.8 sys.version_info checks
Fixed botocore test failure
Applied ruff formatting

Fixes open-telemetry/opentelemetry-python#4513

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Tested locally with tox
Tested in CI

Does This PR Require a Core Repo Change?

Yes. - Link to PR: [WIP] Chore: Drop support for Python 3.8 opentelemetry-python#4520
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

...us-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/gogoproto/gogo_pb2.py

jomcgi · 2025-04-01T20:53:25Z

pyproject.toml

+# Starlette instrumentation is pinned to <0.15 from 2021-06-23
+# This creates a dependency conflict with instrumentation-genai/opentelemetry-instrumentation-google-genai
+# TODO: remove exclusion when #3317 is resolved.
 exclude = [
-  "instrumentation-genai/opentelemetry-instrumentation-google-genai",
+  "instrumentation/opentelemetry-instrumentation-starlette",
 ]


I think flipping this exclusion makes more sense given how outdated the starlette instrumentation is.

I think is going to be resolved in the fastapi middleware PR we have open

I'm not sure the fastapi middleware PR will solve that, but I'm ok with excluding it. We'll probably need to exclude it in the fastapi PR as well to make CI pass.

jomcgi · 2025-04-01T22:48:35Z

tox.ini

+    # excluded from pypy3 due to missing wheel
+    pypy3.10-test-exporter-prometheus-remote-write


pypy3.9 is missing a wheel for cramjam causing this test to fail, if we feel it's necessary we could reopen milesgranger/cramjam#185

jomcgi · 2025-04-01T23:00:28Z

...metry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/lmbd.py

    op.operation_name(): op
    for op in globals().values()
    if inspect.isclass(op)
+    and hasattr(op, "operation_name")


This condition was added here, lmdb.py and sns.py to resolve a test failure where inspect.isclass(op) returned true but issubclass(op, ... failed due to a value from globals not being recognized as a class.

Wondering why they are not failing now though

dimastbk · 2025-04-02T10:52:28Z

...pentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py

@@ -59,7 +60,7 @@


 class Boto3SQSGetter(Getter[CarrierT]):
-    def get(self, carrier: CarrierT, key: str) -> Optional[List[str]]:
+    def get(self, carrier: CarrierT, key: str) -> Optional[list[str]]:


Maybe use from __future__ import annotations whenever possible? Upgrading a code from 3.9 to 3.10 (and 3.11-3.13) will not require many changes.

Maybe https://docs.astral.sh/ruff/rules/future-rewritable-type-annotation/ can help with it.

+1 I would prefer not touching too much code on that PR.

After I followed through with these changes (pyupgrade, ruff/isort enforcing future annotations) the blast radius was massive.
I've removed type changes from this PR as that change does not need to be coupled to deprecating python 3.8.
I can follow-up with the changes I had in smaller separate PRs.

Issue to track enabling the checks: #3428

pyproject.toml

xrmx

I would have preferred to decouple bumping the baseline to the changes to the other hundreds of files 😅

.github/workflows/generate_workflows_lib/src/generate_workflows_lib/__init__.py

jomcgi · 2025-04-11T09:21:50Z

I would have preferred to decouple bumping the baseline to the changes to the other hundreds of files 😅

Agree - it's why this is still in draft.
Most of the type changes can be submitted separately, this definitely doesn't need to be coupled.

Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support ended on 2024-04-07. Changes: * Updated basline refs to 3.9 * Removed 3.8 sys.version_info checks * Fixed botocore test failure * Applied ruff formatting

emdneto · 2025-04-16T19:44:48Z

instrumentation/opentelemetry-instrumentation-psycopg/pyproject.toml

@@ -19,7 +19,6 @@ classifiers = [
  "Programming Language :: Python",
  "Programming Language :: Python :: 3",
  "Programming Language :: Python :: 3.7",
-  "Programming Language :: Python :: 3.8",


We need to revisit this later 😓 we don't even support 3.7.

xrmx · 2025-04-17T12:22:16Z

instrumentation/opentelemetry-instrumentation-psycopg/pyproject.toml

@@ -19,7 +19,6 @@ classifiers = [
  "Programming Language :: Python",
  "Programming Language :: Python :: 3",
  "Programming Language :: Python :: 3.7",


Suggested change

"Programming Language :: Python :: 3.7",

Need to update the requires-python >= 3.7 too

emdneto · 2025-04-17T12:51:03Z

CHANGELOG.md

@@ -48,6 +48,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  ([[#3332](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3332)])


+### Deprecated


Remind to update this

jomcgi mentioned this pull request Apr 1, 2025

[WIP] Chore: Drop support for Python 3.8 open-telemetry/opentelemetry-python#4520

Draft

12 tasks

github-actions bot assigned alizenhom, codeboten, codefromthecrypt, federicobond, gyliu513, jomcgi, karthikscale3, lmolkova, lzchen and NathanielRN Apr 1, 2025

xrmx reviewed Apr 1, 2025

View reviewed changes

...us-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/gogoproto/gogo_pb2.py Outdated Show resolved Hide resolved

jomcgi force-pushed the chore-4513/drop-py38-support branch from 26c0f26 to 71eb61e Compare April 1, 2025 20:49

jomcgi commented Apr 1, 2025

View reviewed changes

jomcgi force-pushed the chore-4513/drop-py38-support branch 2 times, most recently from fba15e8 to e2360f6 Compare April 1, 2025 22:44

jomcgi commented Apr 1, 2025

View reviewed changes

jomcgi force-pushed the chore-4513/drop-py38-support branch from e2360f6 to 4f57fa3 Compare April 1, 2025 23:00

dimastbk reviewed Apr 2, 2025

View reviewed changes

jomcgi force-pushed the chore-4513/drop-py38-support branch from 4f57fa3 to 415fb0c Compare April 4, 2025 08:33

jomcgi commented Apr 4, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

jomcgi commented Apr 4, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

jomcgi force-pushed the chore-4513/drop-py38-support branch 2 times, most recently from 5e91bf0 to cbac8ca Compare April 4, 2025 09:07

xrmx reviewed Apr 11, 2025

View reviewed changes

.github/workflows/generate_workflows_lib/src/generate_workflows_lib/__init__.py Outdated Show resolved Hide resolved

jomcgi force-pushed the chore-4513/drop-py38-support branch 3 times, most recently from 81f758e to b5dbc7b Compare April 16, 2025 08:24

Chore: Drop support for Python 3.8

7af57d4

Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support ended on 2024-04-07. Changes: * Updated basline refs to 3.9 * Removed 3.8 sys.version_info checks * Fixed botocore test failure * Applied ruff formatting

jomcgi force-pushed the chore-4513/drop-py38-support branch from b5dbc7b to 7af57d4 Compare April 16, 2025 08:38

jomcgi changed the title ~~[WIP] Chore: Drop support for Python 3.8~~ Chore: Drop support for Python 3.8 Apr 16, 2025

jomcgi marked this pull request as ready for review April 16, 2025 08:46

jomcgi requested a review from a team as a code owner April 16, 2025 08:46

jomcgi mentioned this pull request Apr 16, 2025

Enable future annotations check in ruff/isort to reduce churn during python upgrades #3428

Open

emdneto reviewed Apr 16, 2025

View reviewed changes

xrmx reviewed Apr 17, 2025

View reviewed changes

emdneto reviewed Apr 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Drop support for Python 3.8 #3399

Chore: Drop support for Python 3.8 #3399

jomcgi commented Apr 1, 2025 •

edited

Loading

jomcgi Apr 1, 2025

xrmx Apr 11, 2025

emdneto Apr 17, 2025

jomcgi Apr 1, 2025

jomcgi Apr 1, 2025

xrmx Apr 17, 2025

dimastbk Apr 2, 2025 •

edited

Loading

emdneto Apr 2, 2025

jomcgi Apr 4, 2025

jomcgi Apr 16, 2025 •

edited

Loading

xrmx left a comment

jomcgi commented Apr 11, 2025

emdneto Apr 16, 2025

xrmx Apr 17, 2025

emdneto Apr 17, 2025

emdneto Apr 17, 2025

		# excluded from pypy3 due to missing wheel
		pypy3.10-test-exporter-prometheus-remote-write

		@@ -48,6 +48,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
		([[#3332](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3332)])


		### Deprecated

Chore: Drop support for Python 3.8 #3399

Are you sure you want to change the base?

Chore: Drop support for Python 3.8 #3399

Conversation

jomcgi commented Apr 1, 2025 • edited Loading

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dimastbk Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomcgi Apr 16, 2025 • edited Loading

Choose a reason for hiding this comment

xrmx left a comment

Choose a reason for hiding this comment

jomcgi commented Apr 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomcgi commented Apr 1, 2025 •

edited

Loading

dimastbk Apr 2, 2025 •

edited

Loading

jomcgi Apr 16, 2025 •

edited

Loading