-
Notifications
You must be signed in to change notification settings - Fork 685
infra: Automate SHA procedure during releases #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+86
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
aabmass
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Makes sense to me but would like someone else to double check it
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Apr 15, 2025
…not installed (open-telemetry#3424) Signed-off-by: emdneto <[email protected]>
The manual process is something like this atm:
With automation it should be something like:
|
Signed-off-by: emdneto <[email protected]>
lzchen
reviewed
Apr 15, 2025
lzchen
reviewed
Apr 15, 2025
.github/workflows/generate_workflows_lib/src/generate_workflows_lib/lint.yml.j2
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Apr 23, 2025
Signed-off-by: Emídio Neto <[email protected]>
Signed-off-by: Emídio Neto <[email protected]>
lzchen
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to automate the SHA procedure during releases. The rationale is:
For non-PR events (e.g., a push),
CORE_REPO_SHA
defaults to "main".For PRs:
If there’s a label named
release
, use the PR’s head branch (e.g., opentelemetrybot/prepare-release-1.32.0-0.53b0)Else, if there’s a label named "patch-release", use the PR’s base branch (e.g., usually release/v1.32.x-0.53bx)
Otherwise, use "main".
Since only people with write permission can use labels, we are safe here. The automation is basically telling opentelemetrybot to open the release PRs with labels and use the labels to set the correct environment variable for
CORE_REPO_SHA
orCORE_CONTRIB_REPO_SHA
.I tested it locally using act, with the following event and checked tox is using the correct value for installing packages:
and:
Testing the behaviour from release workflows is hard, so I'm open to suggestions in terms of how testing it.