Skip to content

Handle None in OTEL_PROPAGATORS #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 2, 2025

Conversation

suauk
Copy link
Contributor

@suauk suauk commented Apr 16, 2025

Description

Fixes #4143

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py312-test-opentelemetry-api
  • tox -e py312-test-opentelemetry-sdk
  • tox -e mypy

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@suauk suauk requested a review from a team as a code owner April 16, 2025 13:41
@xrmx
Copy link
Contributor

xrmx commented Apr 17, 2025

@suauk Please add a changelog entry and fix the mypy warning

@suauk
Copy link
Contributor Author

suauk commented Apr 17, 2025

@suauk Please add a changelog entry and fix the mypy warning

@xrmx Added the entry and resolved mypy warning

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label May 1, 2025
@suauk
Copy link
Contributor Author

suauk commented May 1, 2025

@emdneto there's a couple failed checks, both seem to be unrelated to any changes in the PR, both seem to be related to invalid github links, I'm not too sure what to do about those, do you have any guidance?

@emdneto
Copy link
Member

emdneto commented May 2, 2025

@emdneto there's a couple failed checks, both seem to be unrelated to any changes in the PR, both seem to be related to invalid github links, I'm not too sure what to do about those, do you have any guidance?

No idea. Probably a problem with the github itself

@lzchen lzchen merged commit f55bcec into open-telemetry:main May 2, 2025
480 of 481 checks passed
@suauk suauk deleted the handle_propagators_none branch May 2, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL_PROPAGATORS does not support "none" value
4 participants