feat: remove tracestate, add lineage support to X-Ray propagator#1380
feat: remove tracestate, add lineage support to X-Ray propagator#1380ezhang6811 wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
2 participants
Leaving this PR as a draft until Lambda has confirmed they are ready for this change across all OTel SDKs. Reviews are welcome in the meantime.
All of OpenTelemetry language SDKs are moving towards support for the Lambda Lineage attribute in the X-Ray trace header via W3C Baggage. See this PR for the equivalent Java solution. This PR updates X-Ray propagator to pass lineage into baggage and inject it into outgoing X-Ray trace header.
The X-Ray propagator in other languages uses a delimiter-based scanning approach to extracting incoming X-Ray trace headers (see Java), whereas the Ruby uses regex matching. I updated the regex string to not only support the Lineage key, but also allow the keys to appear in any order as the other algorithms permit.
In addition, extraneous attributes in the X-Ray trace header are dropped instead of added to the span context's tracestate to match how the trace header is processed in the other language SDKs.