Skip to content

release: Release opentelemetry-resource-detector-aws 0.3.0 (was 0.2.0) #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2025

This pull request prepares new gem releases for the following gems:

  • opentelemetry-resource-detector-aws 0.3.0 (was 0.2.0)

For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.

  • To confirm this release, merge this pull request, ensuring the "release: pending" label is set. The release script will trigger automatically on merge.
  • To abort this release, close this pull request without merging.

The generated changelog entries have been copied below:


opentelemetry-resource-detector-aws

v0.3.0 / 2025-05-07

  • ADDED: Contribute aws lambda resource detector
  • FIXED: Add missing semantic conventions require in AWS resource detectors

Copy link
Contributor Author

github-actions bot commented May 7, 2025

WARNING: An additional commit was added while this release PR was open.
You may need to add to the changelog, or close this PR and prepare a new one.

Commit link: 75ba22b

Message:
fix: Account for nil routes (#1527)

  • fix: Account for nil routes

It seems that there are cases in Rails functional tests where it bypasses the routing system and the action_dispatch.route_uri_pattern header not being set.

https://github.com/rails/rails/blob/747f85f200e7bb2c1a31b4e26e5a5655e2dc0cdc/actionpack/lib/action_dispatch/http/request.rb#L160

  4) SessionsController POST #create when user is not found or not persisted redirects to no access path
     Failure/Error: post :create, params: { provider: 'github' }

     NoMethodError:
       undefined method 'chomp' for nil
     # /usr/local/bundle/gems/opentelemetry-instrumentation-action_pack-0.12.0/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb:56:in 'OpenTelemetry::Instrumentation::ActionPack::Handlers::ActionController#to_span_name_and_attributes'
     # /usr/local/bundle/gems/opentelemetry-instrumentation-action_pack-0.12.0/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb:26:in 'OpenTelemetry::Instrumentation::ActionPack::Handlers::ActionController#start'
     # ./spec/controllers/sessions_controller_spec.rb:28:in 'block (4 levels) in <top (required)>'

Our Test suite executes the routing system so we are unable to recreate this error case.

This change adds safe navigation navigation to avoid running into errors when running Functional Tests and the instrumentation is enabled.

irb(main):003> route_uri_pattern.chomp('(.format)')
(irb):3:in '<main>': undefined method 'chomp' for nil (NoMethodError)
        from <internal:kernel>:168:in 'Kernel#loop'
        from /Users/arielvalentin/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/irb-1.15.2/exe/irb:9:in '<top (required)>'
        from /Users/arielvalentin/.rbenv/versions/3.4.1/bin/irb:25:in 'Kernel#load'
        from /Users/arielvalentin/.rbenv/versions/3.4.1/bin/irb:25:in '<main>'
irb(main):004> route_uri_pattern&.chomp('(.format)')
=> nil
  • squash: Add comments

To explain the lack of test coverage

@arielvalentin arielvalentin deleted the release/opentelemetry-resource-detector-aws branch May 7, 2025 18:36
Copy link
Contributor Author

github-actions bot commented May 7, 2025

Release PR closed without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants