-
Notifications
You must be signed in to change notification settings - Fork 520
Add focused benchmark for metric hotpath #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add focused benchmark for metric hotpath #1389
Conversation
@KallDrexx I used this benchmarks against 1379. And here is my results (~16% boost). Could you check if you see similar?
|
The benchmark result of the test on my machine (~ 20% boost): for main branch:
for #1379 PR:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=====================================
Coverage 57.2% 57.2%
=====================================
Files 146 146
Lines 18128 18128
=====================================
+ Hits 10371 10372 +1
+ Misses 7757 7756 -1 ☔ View full report in Codecov by Sentry. |
…cijothomas/opentelemetry-rust into cijothomas/metric_bench_smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging now, as to leverage this for the pending PRs. Happy to address any additional feedbacks as followups. |
I understand we have a lot of benchmarks, but I wanted to add something very focused, to help with PRs like #1379 (and its many follow ups).
Also added dedicated one for AttributeSet creation costs for various scenarios.
It okay to nuke these once the perf improvements are done, but I hope this is very useful to quickly measure PRs impact.
I was able to use this with #1379, and was able to quickly see the improvement.