-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AtomicI64, AtomicU64 for build mipsel processor #2301
base: main
Are you sure you want to change the base?
fix: AtomicI64, AtomicU64 for build mipsel processor #2301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
=====================================
Coverage 79.1% 79.1%
=====================================
Files 119 119
Lines 22555 22555
=====================================
Hits 17842 17842
Misses 4713 4713 ☔ View full report in Codecov by Sentry. |
ref: #2054 |
@@ -18,6 +18,12 @@ pub(crate) use exponential_histogram::{EXPO_MAX_SCALE, EXPO_MIN_SCALE}; | |||
use once_cell::sync::Lazy; | |||
use opentelemetry::{otel_warn, KeyValue}; | |||
|
|||
#[cfg(any(target_arch = "mips", target_arch = "powerpc"))] | |||
use portable_atomic::{AtomicBool, AtomicI64, AtomicU64, AtomicUsize}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these the only place this SDK uses Atomics?
could you add this for xtensa arch too? I'm trying to use this sdk on ESP32 and getting this error:
|
@TGLuong Hi do you have bandwidth to continue working on this? |
@brunobrolesi Would you be willing to take over and continue this work? We can give @TGLuong few days to respond, and then you can pick this up, if you are okay! |
c556cca
to
f000612
Compare
@cijothomas Sorry for the delay, I did get around to implementing the fix locally, but I ran into more problems that will prevent me from continuing development for the time being. For the xtensa architecture, these problems exist in the hyper and socket 2 libs and prevent the use of otel with exporters that use http. hyperium/hyper#3684 Note: Adding target_arch = “xtensa” to the same places where @TGLuong had added the validations allowed me to use the stdout exporter |
Thanks for checking. Looks like these architectures could use a formal, production ready stdout exporter - #2602 |
Fixes #
Design discussion issue (if applicable) #
Changes
AtomicI64
,AtomicU64
in std.Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes