Log - modify export/processor to not require mutable self in shutdown and set-resource #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
reviewed
Feb 7, 2025
| } | ||
|
|
||
| impl<T: LogExporter> SimpleLogProcessor<T> { | ||
| pub(crate) fn new(exporter: T) -> Self { | ||
| SimpleLogProcessor { | ||
| exporter: Mutex::new(exporter), | ||
| is_shutdown: AtomicBool::new(false), | ||
| exporter: exporter |
There was a problem hiding this comment.
I believe the purpose of Mutex lock was to ensure that the multiple exports are not invoked concurrently.
There was a problem hiding this comment.
good point! We need to enforce that spec requirement.
Will see how to do it without Mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And let the component that needs mutability rely on interior mutability. Most of it already uses interior mutability.
Metric already does not require mutable self on shutdown, this makes Logs consistent with that, and later we need to get Traces too.
DRAFT as I am still working through OTLP.