Skip to content

feat: Add ability to specify cardinality limit via Instrument advice #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Apr 5, 2025

Continuing from #2901
This adds ability to configure cardinality_limit via Instrument Advisory Parameter.
Added tests to cover the new addition.

Still pending is the test coverage for all other instrument types and doc updates. This will be follow ups.

Note that OTel spec does not have anything (yet) for configuring cardinality limits via Advisory. But spec does not prohibit language specific additions either. We could make this under feature flag - if anyone feels strongly about this, please let me know in comments, and I can add a feature flag. Given cardinality limit is a well understood concept (stable spec), I don't see any risk with exposing public API for the same via Advisory. Exposing another feature flag, documenting it, and later removing it is not worth IMHO.

@cijothomas cijothomas requested a review from a team as a code owner April 5, 2025 00:11
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 85.57692% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (1760889) to head (e2fc6f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry/src/metrics/instruments/mod.rs 38.8% 11 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 94.2% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #2903    +/-   ##
======================================
  Coverage   81.3%   81.3%            
======================================
  Files        126     126            
  Lines      24156   24256   +100     
======================================
+ Hits       19649   19734    +85     
- Misses      4507    4522    +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit df26240 into open-telemetry:main Apr 8, 2025
24 checks passed
@cijothomas cijothomas deleted the cijothomas/cardinality-advice branch April 8, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants