-
Notifications
You must be signed in to change notification settings - Fork 524
feat: Add ability to specify cardinality limit via Instrument advice #2903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cijothomas
merged 8 commits into
open-telemetry:main
from
cijothomas:cijothomas/cardinality-advice
Apr 8, 2025
Merged
feat: Add ability to specify cardinality limit via Instrument advice #2903
cijothomas
merged 8 commits into
open-telemetry:main
from
cijothomas:cijothomas/cardinality-advice
Apr 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
======================================
Coverage 81.3% 81.3%
======================================
Files 126 126
Lines 24156 24256 +100
======================================
+ Hits 19649 19734 +85
- Misses 4507 4522 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
utpilla
reviewed
Apr 5, 2025
utpilla
reviewed
Apr 5, 2025
utpilla
reviewed
Apr 5, 2025
utpilla
reviewed
Apr 5, 2025
utpilla
reviewed
Apr 5, 2025
utpilla
approved these changes
Apr 5, 2025
lalitb
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #2901
This adds ability to configure cardinality_limit via Instrument Advisory Parameter.
Added tests to cover the new addition.
Still pending is the test coverage for all other instrument types and doc updates. This will be follow ups.
Note that OTel spec does not have anything (yet) for configuring cardinality limits via Advisory. But spec does not prohibit language specific additions either. We could make this under feature flag - if anyone feels strongly about this, please let me know in comments, and I can add a feature flag. Given cardinality limit is a well understood concept (stable spec), I don't see any risk with exposing public API for the same via Advisory. Exposing another feature flag, documenting it, and later removing it is not worth IMHO.