-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADOT instrumentations to distribution list #6168
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additions look good, but can you undo the deletion of the devex survey?
c22eb57
to
352f7e9
Compare
components: [Node] | ||
- name: AWS AWS Distro for OpenTelemetry - Instrumentation for Python | ||
url: https://github.com/aws-observability/aws-otel-python | ||
docsUrl: https://github.com/aws-observability/aws-otel-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svrnm - what's acceptable here in terms of a link to docs. I'd rather this field be empty than point just to the repo. I don't see any docs there, unless you consider the README as being the docs @garysassano?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that many elements in the list followed that approach, so I did the same. If you'd rather remove the docsUrl
, I'm okay with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks. I'm waiting on @svrnm's feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need the docsUrl, or the validation fails, so let's leave it for now, we need to review the registry anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix the validation, 😄 (not in the scope of this PR, of course) rather than have to supply a bogus value?
we need to review the registry anyways.
Is there an issue open so that we can track specific changes (like this one regarding validation of the docsUrl
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix the validation, 😄 (not in the scope of this PR, of course) rather than have to supply a bogus value?
yes
we need to review the registry anyways.
Is there an issue open so that we can track specific changes (like this one regarding validation of the
docsUrl
)?
no, a lot of the issues with the registry are not tracked
/fix:refcache |
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13111369752 |
IMPORTANT: (RE-)RUN
|
No description provided.