Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADOT instrumentations to distribution list #6168

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

garysassano
Copy link
Contributor

No description provided.

@garysassano garysassano requested a review from a team as a code owner February 2, 2025 01:53
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions look good, but can you undo the deletion of the devex survey?

components: [Node]
- name: AWS AWS Distro for OpenTelemetry - Instrumentation for Python
url: https://github.com/aws-observability/aws-otel-python
docsUrl: https://github.com/aws-observability/aws-otel-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm - what's acceptable here in terms of a link to docs. I'd rather this field be empty than point just to the repo. I don't see any docs there, unless you consider the README as being the docs @garysassano?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that many elements in the list followed that approach, so I did the same. If you'd rather remove the docsUrl, I'm okay with that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks. I'm waiting on @svrnm's feedback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need the docsUrl, or the validation fails, so let's leave it for now, we need to review the registry anyways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the validation, 😄 (not in the scope of this PR, of course) rather than have to supply a bogus value?

we need to review the registry anyways.

Is there an issue open so that we can track specific changes (like this one regarding validation of the docsUrl)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the validation, 😄 (not in the scope of this PR, of course) rather than have to supply a bogus value?

yes

we need to review the registry anyways.

Is there an issue open so that we can track specific changes (like this one regarding validation of the docsUrl)?

no, a lot of the issues with the registry are not tracked

@chalin
Copy link
Contributor

chalin commented Feb 3, 2025

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13111369752

@opentelemetrybot
Copy link
Collaborator

fix:refcache was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants