Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] update contributing/_index ja page #6179

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[ja] update contributing/_index ja page #6179

merged 2 commits into from
Feb 10, 2025
+33 −14

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Feb 2, 2025 •
edited
Loading

update contributing page in ja because it is outdated.

issue: #6172

@opentelemetrybot opentelemetrybot requested review from a team February 2, 2025 23:12
@Msksgm Msksgm force-pushed the update-#6172/ja/contributing branch from 3f4f160 to 56bc126 Compare February 3, 2025 00:10
@Msksgm Msksgm marked this pull request as ready for review February 3, 2025 00:11
@Msksgm Msksgm requested a review from a team as a code owner February 3, 2025 00:11
@Msksgm Msksgm force-pushed the update-#6172/ja/contributing branch 3 times, most recently from a7c6905 to fe20710 Compare February 8, 2025 00:35
ymotongpoo
ymotongpoo approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 10, 2025
@ymotongpoo ymotongpoo force-pushed the update-#6172/ja/contributing branch from fe20710 to 89a1f0b Compare February 10, 2025 03:30
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 03:31
chalin
chalin approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See inline comment for suggestion -- let me know if this is what you prefer.

content/ja/docs/contributing/_index.md Outdated Show resolved Hide resolved
@chalin chalin removed the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 10, 2025
@Msksgm Msksgm force-pushed the update-#6172/ja/contributing branch from 89a1f0b to 7682dca Compare February 10, 2025 11:41
@opentelemetrybot opentelemetrybot requested review from a team February 10, 2025 11:41
@chalin chalin added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-telemetry:main with commit fe3a5ee Feb 10, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@Msksgm Msksgm deleted the update-#6172/ja/contributing branch February 10, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymotongpoo ymotongpoo ymotongpoo approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Msksgm @opentelemetrybot @ymotongpoo @chalin