Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate contributing/pull-requests into ja #6197

Merged
merged 11 commits into from
Feb 10, 2025

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Feb 4, 2025

translated contributing/pull-requests page into ja.

@opentelemetrybot opentelemetrybot requested review from a team February 4, 2025 12:05
@Msksgm Msksgm force-pushed the ja/contributing/pull-requests branch 14 times, most recently from 5715ca7 to 432fb53 Compare February 7, 2025 23:40
@Msksgm Msksgm changed the title [ja] translate contributing/pull-requests into ja [ja] translate contributing/pull-requests and contributing/pr-checks into ja Feb 7, 2025
@Msksgm Msksgm force-pushed the ja/contributing/pull-requests branch 4 times, most recently from 6c9c813 to 30ef546 Compare February 8, 2025 00:45
@Msksgm Msksgm changed the title [ja] translate contributing/pull-requests and contributing/pr-checks into ja [ja] translate contributing/pull-requests into ja Feb 8, 2025
@Msksgm Msksgm force-pushed the ja/contributing/pull-requests branch 6 times, most recently from 90a1245 to 1b644a5 Compare February 9, 2025 06:15
@Msksgm Msksgm marked this pull request as ready for review February 9, 2025 07:17
@Msksgm Msksgm requested a review from a team as a code owner February 9, 2025 07:17
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @Msksgm. I left some comments.

{{% alert title="ヒント: Draft ステータス" %}}

コンテンツがレビューの準備ができていないことをメンテナーに知らせるために、プルリクエストのステータスを **Draft** にしてください。
メンテナーは、Draft ステータスを解除するまでコンテンツを完全にレビューしませんが、コメントや高レベルのレビューを行うことがあります。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完全にレビューしませんが→完全なレビューはしませんが

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

698591e

subgraph first[コントリビュートする方法]
direction TB
T[ ] -.-
B[GitHub でフォークする] --- C[マークダウンでドキュメントを作成する<br>Hugo でサイトをビルドする]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは「マークダウン」より「Markdown」のほうがよさそう

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

f679313


{{% alert title="Contributor License Agreement (CLA)" color=warning %}}

すべてのコントリビューターは、変更が承認されてマージされる前に、[コントリビューター ライセンス契約 (CLA)][CLA] に署名する必要があります。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初出の英語に関して訳す場合は、カッコ内に元の英語を追加したほうが優しいです。

「コントリビューターライセンス契約(Contributor License Agreement、CLA)」

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

11517e0

subgraph tasks[GitHub を使用した変更]
direction TB
0[ ] -.-
1[1\. ページを編集] --> 2[2\. GitHub マークダウンエディターを利用して変更を加える]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

f679313


1. **Create pull request**を選択してください。

プルリクエストをマージする前に、OpenTelemetry コミュニティメンバーはレビューしてアプルーブします。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは迷うけど「承認」のほうが良さそう

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

469b919

git remote add upstream https://github.com/open-telemetry/opentelemetry.io.git
```

1. `origin` and `upstream` リポジトリの確認。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳し漏れ and

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

be6736c

upstream https://github.com/open-telemetry/opentelemetry.io.git (push)
```

1. フォークの `origin/main` と `open-telemetry/opentelemetry.io`'s `upstream/main` からコミットをフェッチ。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳し漏れ 's

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

88cb1cf

PR を公開した後に、自動テストの実行と [Netlify](https://www.netlify.com/) を使用したプレビューのデプロイを試みます。

- Netlify ビルドが失敗した場合、詳細な情報のために **Details** を選択してください。
- Netify のビルドが成功した場合、**Details** を選択して、変更が適用された OpenTelemetry のウェブサイトのステージングバージョンを開いてください。 これがレビュアーが変更を確認する方法です。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlifyのtypo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

05e14cf

- Netlify ビルドが失敗した場合、詳細な情報のために **Details** を選択してください。
- Netify のビルドが成功した場合、**Details** を選択して、変更が適用された OpenTelemetry のウェブサイトのステージングバージョンを開いてください。 これがレビュアーが変更を確認する方法です。

他のチェックも同様に失敗している可能性があります。[全ての PR チェック](../pr-checks) を参照してください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全て→すべて 開く

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

2d659fb

@Msksgm Msksgm force-pushed the ja/contributing/pull-requests branch from 1987b4d to 2d659fb Compare February 10, 2025 07:28
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 07:29
@Msksgm
Copy link
Contributor Author

Msksgm commented Feb 10, 2025

@ymotongpoo

Thank you for you review. I handled your comment.
Please check it.
Thank you.

@ymotongpoo ymotongpoo force-pushed the ja/contributing/pull-requests branch from 2d659fb to 2463e40 Compare February 10, 2025 09:06
@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 10, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-telemetry:main with commit 8fbd3a5 Feb 10, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Development

Successfully merging this pull request may close these issues.

4 participants