-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] translate contributing/pull-requests into ja #6197
[ja] translate contributing/pull-requests into ja #6197
Conversation
5715ca7
to
432fb53
Compare
6c9c813
to
30ef546
Compare
90a1245
to
1b644a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @Msksgm. I left some comments.
{{% alert title="ヒント: Draft ステータス" %}} | ||
|
||
コンテンツがレビューの準備ができていないことをメンテナーに知らせるために、プルリクエストのステータスを **Draft** にしてください。 | ||
メンテナーは、Draft ステータスを解除するまでコンテンツを完全にレビューしませんが、コメントや高レベルのレビューを行うことがあります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
完全にレビューしませんが→完全なレビューはしませんが
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
subgraph first[コントリビュートする方法] | ||
direction TB | ||
T[ ] -.- | ||
B[GitHub でフォークする] --- C[マークダウンでドキュメントを作成する<br>Hugo でサイトをビルドする] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここは「マークダウン」より「Markdown」のほうがよさそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
|
||
{{% alert title="Contributor License Agreement (CLA)" color=warning %}} | ||
|
||
すべてのコントリビューターは、変更が承認されてマージされる前に、[コントリビューター ライセンス契約 (CLA)][CLA] に署名する必要があります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
初出の英語に関して訳す場合は、カッコ内に元の英語を追加したほうが優しいです。
「コントリビューターライセンス契約(Contributor License Agreement、CLA)」
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
subgraph tasks[GitHub を使用した変更] | ||
direction TB | ||
0[ ] -.- | ||
1[1\. ページを編集] --> 2[2\. GitHub マークダウンエディターを利用して変更を加える] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
|
||
1. **Create pull request**を選択してください。 | ||
|
||
プルリクエストをマージする前に、OpenTelemetry コミュニティメンバーはレビューしてアプルーブします。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここは迷うけど「承認」のほうが良さそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
git remote add upstream https://github.com/open-telemetry/opentelemetry.io.git | ||
``` | ||
|
||
1. `origin` and `upstream` リポジトリの確認。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
訳し漏れ and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my mistake. I fixed a bellow commit.
upstream https://github.com/open-telemetry/opentelemetry.io.git (push) | ||
``` | ||
|
||
1. フォークの `origin/main` と `open-telemetry/opentelemetry.io`'s `upstream/main` からコミットをフェッチ。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
訳し漏れ 's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my mistake. I fixed a bellow commit.
PR を公開した後に、自動テストの実行と [Netlify](https://www.netlify.com/) を使用したプレビューのデプロイを試みます。 | ||
|
||
- Netlify ビルドが失敗した場合、詳細な情報のために **Details** を選択してください。 | ||
- Netify のビルドが成功した場合、**Details** を選択して、変更が適用された OpenTelemetry のウェブサイトのステージングバージョンを開いてください。 これがレビュアーが変更を確認する方法です。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Netlifyのtypo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my mistake. I fixed a bellow commit.
- Netlify ビルドが失敗した場合、詳細な情報のために **Details** を選択してください。 | ||
- Netify のビルドが成功した場合、**Details** を選択して、変更が適用された OpenTelemetry のウェブサイトのステージングバージョンを開いてください。 これがレビュアーが変更を確認する方法です。 | ||
|
||
他のチェックも同様に失敗している可能性があります。[全ての PR チェック](../pr-checks) を参照してください。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全て→すべて 開く
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I fixed a bellow commit.
1987b4d
to
2d659fb
Compare
Thank you for you review. I handled your comment. |
…m a fork` into param
…ated from a fork` into param" This reverts commit 6114eb1.
Because it is a function of GitHub UI, translaters consider that these words should be English.
2d659fb
to
2463e40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey |
translated contributing/pull-requests page into ja.