Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Refresh refcache, fix external links with invalid fragments #6206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[chore] Refresh refcache, fix external links with invalid fragments #6206

wants to merge 4 commits into from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 4, 2025 •
edited
Loading

  • Contributes to [chore] Ensure that external link fragments are valid #6196
  • Refreshes the refcache, in particular by validating external links with fragments. Such valid links now have status 21X in the refcache file, so that I can differentiate them from links that haven't had their fragments validated yet. The PR includes only some updates, more are to come, but it touched enough files across SIGs that it seemed like enough of an increment to submit a PR for.
  • Marks external URLs with yet-to-be-validated fragments with 204 status
  • Note that might squash some of the commits of this PR before merging, but it isn't really necessary since PRs are merge-squashed anyways. There are lots of "w" (for WIP) commits because I made the link updates incrementally.

@chalin chalin added CI/infra CI & infrastructure cleanup/refactoring labels Feb 4, 2025
@chalin chalin requested a review from a team as a code owner February 4, 2025 14:46
@chalin chalin marked this pull request as draft February 4, 2025 14:46
@opentelemetrybot opentelemetrybot requested review from a team February 4, 2025 14:47
chalin
chalin commented Feb 4, 2025
View reviewed changes
data/registry/application-integration-python-cisco-nso.yml
docs: https://developer.cisco.com/docs/nso/#!observability-exporter/
docs: https://developer.cisco.com/docs/nso/observability-exporter/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm - is this change ok?

@chalin chalin force-pushed the chalin-im-test-url-fragments-2025-02-04 branch from 9a45590 to 9c29b82 Compare February 4, 2025 14:52
@chalin chalin marked this pull request as ready for review February 4, 2025 14:52
@chalin chalin mentioned this pull request Feb 4, 2025
Open
10 tasks
@chalin chalin force-pushed the chalin-im-test-url-fragments-2025-02-04 branch from 9c29b82 to b47bfc9 Compare February 4, 2025 15:01
tiffany76
tiffany76 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

kaylareopelle
kaylareopelle approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby file update looks good.

Kielek
Kielek approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET part LGTM

@chalin chalin force-pushed the chalin-im-test-url-fragments-2025-02-04 branch from b47bfc9 to e432547 Compare February 5, 2025 13:42
@opentelemetrybot opentelemetrybot requested review from a team February 5, 2025 13:42
@chalin chalin force-pushed the chalin-im-test-url-fragments-2025-02-04 branch from e432547 to d2d1fc6 Compare February 5, 2025 14:01
@chalin
Copy link
Contributor Author

chalin commented Feb 5, 2025

@jack-berg @jaydeluca - apply the changes you suggested. PTAL and approve for the Java folks. Thx

@opentelemetrybot opentelemetrybot requested a review from a team February 5, 2025 16:04
@chalin chalin force-pushed the chalin-im-test-url-fragments-2025-02-04 branch from e0335e7 to 65867d1 Compare February 5, 2025 16:07
@chalin chalin requested review from jack-berg and jaydeluca February 5, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias left review comments

@swiatekm swiatekm swiatekm approved these changes

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@rogercoll rogercoll rogercoll approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

@reyang reyang reyang approved these changes

@Kielek Kielek Kielek approved these changes

@mx-psi mx-psi mx-psi approved these changes

@jack-berg jack-berg Awaiting requested review from jack-berg

@jaydeluca jaydeluca Awaiting requested review from jaydeluca

Assignees
No one assigned
Labels
blog CI/infra CI & infrastructure cleanup/refactoring registry sig:demo sig:dotnet sig:java sig:operator sig:php sig:ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.