Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Move NET_TCP/UDP_HAVE_STACK to netconfig.h #11

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

wengzhe
Copy link
Member

@wengzhe wengzhe commented Dec 20, 2024

Summary

Now the HAVE_PFINET(6)_SOCKETS depends on NET_TCP/UDP_HAVE_STACK, which is previously defined in net/ folder and cannot be included. Considering many places use this check, maybe moving them to netconfig.h could be better.

Impact

Before: IPv4 + TCP, without ICMP -> HAVE_PFINET_SOCKETS is undefined, we cannot use TCP socket (error is EAFNOSUPPORT)
After: IPv4 + TCP, without ICMP -> HAVE_PFINET_SOCKETS is defined, we can use TCP socket

Testing

QEMU with CONFIG_NET_IPv4 & CONFIG_NET_TCP enabled but CONFIG_NET_ICMP_SOCKET disabled.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wengzhe
❌ PetervdPerk-NXP
You have signed the CLA already but the status is still pending? Let us recheck it.

PetervdPerk-NXP and others added 3 commits December 20, 2024 15:31
Fixes psock_socket: ERROR: socket address family unsupported: 2
When using the minimal CONFIG_NET configuration typically used for
SocketCAN

Update net/inet/inet.h

Co-authored-by: Xiang Xiao <[email protected]>

Update net/inet/inet.h

Co-authored-by: Xiang Xiao <[email protected]>
Define wasn't imported by netconfig.h move definitions
@pengxianghao21 pengxianghao21 merged commit 318e51c into open-vela:dev Dec 23, 2024
3 of 4 checks passed
@wengzhe wengzhe deleted the openvela-sync branch December 23, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants