boards: Replace CONFIG_NSH_LINELEN with CONFIG_LINE_MAX
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing debug configs Signed-off-by: wangjianyu3 <[email protected]>
With patch apache/nuttx#15531 Signed-off-by: wangjianyu3 <[email protected]>
The large max command line length may cause stack overflow. Test ./tools/configure.sh lm3s6965-ek:qemu-flat make -j16 qemu-system-arm -semihosting \ -M lm3s6965evb \ -device loader,file=nuttx.bin,addr=0x00000000 \ -netdev user,id=user0 \ -serial mon:stdio -nographic Link: apache/nuttx-apps#2850 Signed-off-by: wangjianyu3 <[email protected]>
Details: apache/nuttx-apps#2943 1. find boards/ -name defconfig | xargs sed -i 's/CONFIG_NSH_LINELEN/CONFIG_LINE_MAX/g' 2. ./tools/refresh.sh --silent --defaults all Signed-off-by: wangjianyu3 <[email protected]>
remove temporary emacs file added by accident Signed-off-by: raiden00pl <[email protected]>
Log
$ ./tools/refresh.sh --silent --defaults arch:risc-v
Normalizing all boards in arch: risc-v !
[1/227] Normalize arty_a7/nsh
[2/227] Normalize arty_a7/netnsh
[3/227] Normalize arty_a7/knsh
# ... ...
Signed-off-by: wangjianyu3 <[email protected]>
|
|
|
@raiden00pl Could you take a look about the CLA please ;-) |
JianyuWang0623
requested review from
xiaoxiang781216 and
GUIDINGLI
as code owners
xiaoxiang781216
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
boards: Replace
CONFIG_NSH_LINELENwithCONFIG_LINE_MAXDetails: apache/nuttx-apps#2943
1. find boards/ -name defconfig | xargs sed -i 's/CONFIG_NSH_LINELEN/CONFIG_LINE_MAX/g'
7. ./tools/refresh.sh --silent --defaults all
Impact
boards/*
Testing