Syslog inbuffer #199
Merged
Syslog inbuffer #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k scenario Summary: When spinlock.h is enabled in a single-core scenario, spinlock reentry and exceptions may occur when spin_lock_irqsave_wo_note is used in syslog_add_intbuffer Signed-off-by: chenrun1 <[email protected]>
just read the code, still have the deadlock after below change: | commit 3b6f463ce2b54d1934e4357b4ea1d81635161c95 | Author: chenrun1 <[email protected]> | Date: Tue Dec 31 14:31:46 2024 +0800 | | syslog_inbuffer:Fixed the lock reentry issue in single core + spinlock scenario | | Summary: | When spinlock.h is enabled in a single-core scenario, spinlock reentry and exceptions may occur when spin_lock_irqsave_wo_note is used in syslog_add_intbuffer | | Signed-off-by: chenrun1 <[email protected]> Signed-off-by: chao an <[email protected]>
xiaoxiang781216
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When spinlock.h is enabled in a single-core scenario, spinlock reentry and exceptions may occur when spin_lock_irqsave_wo_note is used in syslog_add_intbuffer
Impact
Fixed deadlock problem with syslog_inbuffer
Testing
Spinlock is turned on in single-core Qemu for testing. It works normally during crash, avoiding being stuck