feat: Client identities list screen with new UI #2483
Conversation
|
@TheKalpeshPawar i think, you having issues with your internet. Can you review the code instead |
| modifier = Modifier.fillMaxSize() | ||
| .padding(paddingValues) | ||
| .padding(DesignToken.padding.large), | ||
| ) { |
There was a problem hiding this comment.
Shouldn't padding(paddingValues) be applied before fillMaxSize() here ?
There was a problem hiding this comment.
I am not sure what you meant by this, but as far as i know, filllMaxSize is usually applied before padding and all.
There was a problem hiding this comment.
shouldn't the padding values of the scaffold be applied before using full screen?
There was a problem hiding this comment.
Not an issue here, but they are for adjusting top and bottom bar heights, which needs to be applied to the content, to adjust it accordingly first.
The padding values provided to your content are only set if you set the bottomBar parameter. This unfortunately is not documented. If you set the bottomBar, the Scaffold will set the bottom padding of PaddingValues to be the height of the content that the bottomBar content uses. The other padding values (start, top, end) are currently set to zero.
There was a problem hiding this comment.
alr, gonna update it
...ommonMain/kotlin/com/mifos/feature/client/clientIdentitiesList/ClientIdentitiesListScreen.kt
Show resolved
Hide resolved
| Surface( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| shape = RoundedCornerShape( | ||
| bottomStart = DesignToken.padding.medium, | ||
| bottomEnd = DesignToken.padding.medium, | ||
| ), | ||
| ) { | ||
| menuList.map { menuItem -> | ||
| Row( | ||
| modifier = Modifier.fillMaxWidth() | ||
| .height(DesignToken.sizes.avatarMedium) | ||
| .clickable { | ||
| onActionClicked(menuItem) | ||
| }, | ||
| verticalAlignment = Alignment.CenterVertically, | ||
| horizontalArrangement = Arrangement.Start, | ||
| ) { | ||
| Icon( | ||
| modifier = Modifier.padding(horizontal = DesignToken.padding.large), | ||
| imageVector = menuItem.icon, | ||
| contentDescription = "", | ||
| ) | ||
| Column( | ||
| modifier = Modifier.padding( | ||
| vertical = DesignToken.padding.small, | ||
| ), | ||
| ) { |
There was a problem hiding this comment.
can you apply the surfaceContainer color to this composable, like shown in the figma design.
There was a problem hiding this comment.
There are few issues with these kind of cards. I am thinking of doing this in a separate ticket because we need to fix this for all the components, and those components have been used in other screens as well.
since this PR is about client identities, touching other screens wont be a good idea... we will fix this in a single PR for all the screens, as changes are similar.
| IconButton( | ||
| onClick = { onAction.invoke(ClientIdentitiesListAction.ToggleSearch) }, | ||
| ) { | ||
| Icon( | ||
| painter = painterResource(Res.drawable.search), | ||
| contentDescription = null, | ||
| ) | ||
| } | ||
|
|
||
| Spacer(modifier = Modifier.height(DesignToken.padding.largeIncreased)) | ||
|
|
||
| IconButton( | ||
| onClick = { onAction.invoke(ClientIdentitiesListAction.AddNewClientIdentity) }, | ||
| ) { | ||
| Icon( | ||
| painter = painterResource(Res.drawable.add_icon), | ||
| contentDescription = null, | ||
| ) | ||
| } |
There was a problem hiding this comment.
can we do this something like this
Row(
horizontalArrangement = Arrangement.spacedBy(20.dp),
) {
Icon(
painter = painterResource(Res.drawable.search),
contentDescription = null,
modifier = Modifier.clickable{
onAction.invoke(ClientIdentitiesListAction.ToggleSearch)
}
)
Icon(
painter = painterResource(Res.drawable.filter),
contentDescription = null,
modifier = Modifier.clickable{
onAction.invoke(ClientIdentitiesListAction.AddNewClientIdentity)
}
)
}this will remove the extra space from the right side of the add icon and make the header look like it is in the figma design.
There was a problem hiding this comment.
yea, ill update it
4 participants
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-585
Screenrecorder-2025-08-31-21-24-53-217.mp4