-
Notifications
You must be signed in to change notification settings - Fork 658
fix notes screen issue #2485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix notes screen issue #2485
Conversation
…1/android-client into fix-notes_screen_issue
feature/note/src/commonMain/kotlin/com/mifos/feature/note/addEditNotes/AddEditNoteScreen.kt
Outdated
Show resolved
Hide resolved
feature/note/src/commonMain/kotlin/com/mifos/feature/note/notes/NoteScreen.kt
Outdated
Show resolved
Hide resolved
|
what happens ? |
|
@Arinyadav1 Please make the following changes, see other screens for reference
|
|
@itsPronay |
|
shape ? elevation? I don't see Empty screen having shave and elevation in figma screen. why do you need it when every empty screen looks the same. |
feature/note/src/commonMain/kotlin/com/mifos/feature/note/notes/NoteScreen.kt
Outdated
Show resolved
Hide resolved
|
Remove custom Note Empty Screen that you made as we already have this component. Use MifosEmptyCard, please understand we about it what you want to change. |

Fixes - Jira-#588
It fix the issue note list not update immediately after update and add note.