MIFOSAC-573 Client Recurring Deposit Accounts #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…counts and GetClientsClientIdAccountMapper to fetch some values. Also added color to the MifosActionsListingCardComponent and removed account number label.
# Conflicts: # core/ui/src/commonMain/kotlin/com/mifos/core/ui/components/MifosActionsListingCardComponent.kt
…counts and GetClientsClientIdAccountMapper to fetch some values. Also added color to the MifosActionsListingCardComponent and removed account number label.
TheKalpeshPawar
changed the title
revanthkumarJ
suggested changes
Sep 1, 2025
core/network/src/commonMain/kotlin/com/mifos/core/network/services/ClientService.kt
Outdated
Show resolved
Hide resolved
revanthkumarJ
approved these changes
Sep 1, 2025
itsPronay
reviewed
Sep 1, 2025
...ain/kotlin/com/mifos/feature/client/recurringDepositAccount/RecurringDepositAccountScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Sep 1, 2025
...ain/kotlin/com/mifos/feature/client/recurringDepositAccount/RecurringDepositAccountScreen.kt
Show resolved
Hide resolved
itsPronay
reviewed
Sep 1, 2025
...ain/kotlin/com/mifos/feature/client/recurringDepositAccount/RecurringDepositAccountScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Sep 1, 2025
...Main/kotlin/com/mifos/feature/client/recurringDepositAccount/RecurringDepositAccountRoute.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Sep 1, 2025
...ain/kotlin/com/mifos/feature/client/recurringDepositAccount/RecurringDepositAccountScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
approved these changes
Sep 1, 2025
revanthkumarJ
approved these changes
Sep 1, 2025
revanthkumarJ
approved these changes
Sep 1, 2025
itsPronay
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature - Jira-#MIFOSAC-573
Things to look carefully:
I have added some parameters in some network modules.
I have changes some parameters in the MifosActionsListingCardComponent to make UI look like the figma design,
but let me know if things were the way they were because of some reason. I will revert things back.
Also I have done something a little different in the UI screen I created. So, please let me know if that is okay otherwise I will change it.
Video
Record_2025-09-01-19-53-06_026f621985d6cfa1a169c52d305dc178.mp4