feat: implement recurring deposit account with stepper UI #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-arth07
reviewed
Oct 16, 2025
| ) { | ||
| val steps = remember { | ||
| listOf( | ||
| Step(name = "Details") { |
Contributor
There was a problem hiding this comment.
Move the hardcoded strings to strings.xml
| onNext = { onAction(RecurringAccountAction.NextStep) }, | ||
| ) | ||
| }, | ||
| Step(name = "Terms") { |
| } | ||
|
|
||
| MifosScaffold( | ||
| title = "Create Recurring Deposit Account", |
Contributor
There was a problem hiding this comment.
Here too, move all the hardcoded strings to strings.xml
Contributor
Author
There was a problem hiding this comment.
fixed all changes
sam-arth07
reviewed
Oct 16, 2025
| when (action) { | ||
| RecurringAccountAction.NextStep -> { | ||
| mutableStateFlow.update { state -> | ||
| val maxIndex = 4 // total steps - 1 (Details, Terms, Settings, Interest, Charges) |
Contributor
There was a problem hiding this comment.
Remove the inline comment
Contributor
Author
There was a problem hiding this comment.
fixed this one too
biplab1
approved these changes
Oct 16, 2025
Contributor
biplab1
left a comment
biplab1
left a comment
There was a problem hiding this comment.
Other than changes requested, this looks good to me. This can be merged after those changes are made.
Contributor
|
The padding don't seem to match for:
Could please check? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WhatsApp.Video.2025-10-15.at.20.58.52_3515005a.mp4
Fixes - Jira-#MIFOSAC-548
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.