Feature :Implement NewFixedDeposit with Stepper UI #2525
Conversation
WhatsApp.Video.2025-10-16.at.21.36.25_aa3cdfcb.mp4video |
|
Always write a pr title. |
# Conflicts: # feature/client/src/commonMain/kotlin/com/mifos/feature/client/navigation/ClientNavigation.kt
|
|
||
| shareAccountDestination() | ||
|
|
||
| recurringAccountDestination() |
There was a problem hiding this comment.
i don't think conflict solved properly you removed this line i added this for recurring account please check
| onNavigateApplyShareAccount = navController::navigateToShareAccountRoute, | ||
| onNavigateApplyLoanAccount = navController::navigateToNewLoanAccountRoute, | ||
| onNavigateApplySavingsAccount = navController::navigateToSavingsAccountRoute, | ||
| onNavigateApplyRecurringAccount = navController::navigateToRecurringAccountRoute, |
WhatsApp.Video.2025-10-17.at.21.32.27_5424e25d.mp4video after changes |
sam-arth07
left a comment
sam-arth07
left a comment
There was a problem hiding this comment.
Add the ticket number as well so that it is easier to track your pr from the jira ticket.
Also, attach the video showcasing the changes made in the pr in the pr description and if any subsequent changes, then update that video in the pr desc, so that it is easy to review afterwards.
| shareAccountDestination() | ||
|
|
||
| recurringAccountDestination() | ||
| fixedAccountdestination() |
There was a problem hiding this comment.
| fixedAccountdestination() | |
| fixedAccountDestination() |
Since at all other places we are using camel case, so it is better to follow it here as well.
There was a problem hiding this comment.
changed to camelcase
| <string name="step_details">Details</string> | ||
| <string name="step_terms">Terms</string> | ||
| <string name="step_settings">Settings</string> | ||
| <string name="step_interest">Interest</string> |
There was a problem hiding this comment.
This should be Interest Chart according to the figma UI mockups.
There was a problem hiding this comment.
tried to fix but did not able for dots
There was a problem hiding this comment.
chart is comming below on the screen ? how should i fix
There was a problem hiding this comment.
You can utilize the overflow property of the Text Composable to achieve this effect.
Something similar to this:
Text(
text = "Lorem ipsum dolor sit amet.",
maxLines = 1,
overflow = TextOverflow.Ellipsis
)
Can read more about this here: https://developer.android.com/reference/kotlin/androidx/compose/ui/text/style/TextOverflow
WhatsApp.Video.2025-10-22.at.00.14.19_3986a36d.mp4video after Adding interest chart |
WhatsApp.Video.2025-10-22.at.13.48.20_82fa0459.mp4video newFixedDeposit Seed Card Stepper |
WhatsApp.Video.2025-10-22.at.20.33.41_a7ef6ac6.mp4Applied spotlessapply |
ankitkumarrain
changed the title
| } | ||
|
|
||
| @Composable | ||
| private fun FixeDepositAccountScaffold( |
There was a problem hiding this comment.
It should be Fixed instead of Fixe. Also, make sure it is fixed anywhere else it is used within the file.
| ) { | ||
| val steps = | ||
| listOf( | ||
| Step(stringResource(Res.string.step_charges)) { |
There was a problem hiding this comment.
the first step is labeled step_charges but uses the DetailsPage, which inside itself uses step_details (See DetailsPage.kt). Make sure the naming of resources is consistent with their usage.
There was a problem hiding this comment.
One can see in the screen also
| import org.jetbrains.compose.resources.stringResource | ||
|
|
||
| @Composable | ||
| fun InterestPage(onNext: () -> Unit) { |
There was a problem hiding this comment.
File name is InterestChargesPage.kt but composable is InterestPage. Either make the file name consistent (InterestPage.kt) or clarify by using the same name throughout.
There was a problem hiding this comment.
Changed to intetestpage
|
https://github.com/user-attachments/assets/6393b1.f8-0d16-4522-ac73-fcc8f0818752 now everything works fine. |
7 participants
Fixes - Jira-#556
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
[ ]
Uploading WhatsApp Video 2025-10-14 at 16.15.50_25401367.mp4…