Skip to content

Conversation

@biplab1
Copy link
Contributor

@biplab1 biplab1 commented Nov 7, 2025

Fixes - Jira-#612

Summary of changes:

  • Removed unused directory mifosng-android.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

Release Notes

  • Removals
    • Removed Google Play Services integration
    • Removed dark theme and night mode support
    • Removed adaptive launcher icons for modern Android devices
    • Removed dynamic app theme customization
    • Simplified navigation architecture and app startup configuration
    • Cleaned up build and release configuration files

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Walkthrough

This PR removes multiple configuration files, navigation infrastructure, state management, theme resources, and Firebase integration from the Mifos Android application. Deletions include the root navigation graph, AndroidClientViewModel, UI theme extensions, adaptive icon resources, theme definitions, and Google services configuration.

Changes

Cohort / File(s) Summary
Configuration & Build Metadata
mifosng-android/google-services.json, mifosng-android/lint-baseline.xml, mifosng-android/prod/release/output-metadata.json
Removed Google Firebase services configuration, lint baseline rules for AGP 8.5.0, and release artifact metadata including version info (2025.3.2-beta.0.4) and baseline profiles.
Navigation & State Management
mifosng-android/src/main/java/com/mifos/mifosxdroid/navigation/RootNavGraph.kt, mifosng-android/src/main/java/com/mifos/mifosxdroid/AndroidClientViewModel.kt
Deleted root navigation setup (NavHost, sub-graphs for auth, server config, passcode, and home) and ViewModel managing UI state, theme preferences, authentication, app restart logic, and countdown toast utilities.
UI Utilities
mifosng-android/src/main/java/com/mifos/mifosxdroid/utils/UiExtensions.kt
Removed extension property Configuration.isSystemInDarkTheme and extension function ComponentActivity.isSystemInDarkTheme(): Flow<Boolean> for system dark theme detection with configuration change listeners.
Launcher Icon Resources
mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher.xml, mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
Removed adaptive icon resource definitions for API 26+ referencing launcher background and foreground drawables.
Theme Resources
mifosng-android/src/main/res/values-night/themes.xml
Deleted night theme style declarations including NightAdjusted.Theme.Mifos and NightAdjusted.Theme.Splash with status bar and navigation bar light appearance settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Note: While deletions span multiple file types (config, navigation, theming, resources), the changes follow a consistent removal pattern with minimal logic density. Primary review focus should verify:
    • No remaining code references the removed ViewModel, navigation graph, or UI extension functions
    • Downstream dependencies on MainState sealed interface and AndroidClientViewModel have been migrated or refactored elsewhere

Poem

🐰 Files deleted, configs gone,
Navigation paths withdrawn,
Themes and icons fade away,
Cleaner code will save the day! ✨
Firebase bids its last goodbye,
As tech debts wave and say goodbye. 👋

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove unused directory mifosng-android' accurately and directly describes the main change: the deletion of the mifosng-android directory and all its contents.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 891a053 and b023e27.

⛔ Files ignored due to path filters (1)
  • mifosng-android/src/main/ic_launcher-playstore.png is excluded by !**/*.png
📒 Files selected for processing (9)
  • mifosng-android/google-services.json (0 hunks)
  • mifosng-android/lint-baseline.xml (0 hunks)
  • mifosng-android/prod/release/output-metadata.json (0 hunks)
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/AndroidClientViewModel.kt (0 hunks)
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/navigation/RootNavGraph.kt (0 hunks)
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/utils/UiExtensions.kt (0 hunks)
  • mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher.xml (0 hunks)
  • mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml (0 hunks)
  • mifosng-android/src/main/res/values-night/themes.xml (0 hunks)
💤 Files with no reviewable changes (9)
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/utils/UiExtensions.kt
  • mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
  • mifosng-android/prod/release/output-metadata.json
  • mifosng-android/src/main/res/values-night/themes.xml
  • mifosng-android/google-services.json
  • mifosng-android/lint-baseline.xml
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/AndroidClientViewModel.kt
  • mifosng-android/src/main/java/com/mifos/mifosxdroid/navigation/RootNavGraph.kt
  • mifosng-android/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@biplab1
Copy link
Contributor Author

biplab1 commented Nov 10, 2025

@niyajali All the checks have completed successfully. If everything looks good, feel free to go ahead and merge this PR.

@biplab1
Copy link
Contributor Author

biplab1 commented Nov 10, 2025

@niyajali Checks have completed. Kindly merge this.

@niyajali niyajali merged commit db683c6 into openMF:development Nov 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants