Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some issues with the Configuration Wizard #2267

Merged

Conversation

steinwinde
Copy link
Contributor

@steinwinde steinwinde commented Feb 16, 2025

Two wizards just ceased showing popups. Another wizard ended in a 404. Many of the popups had problems with the labels (e.g. literally showed the label instead of the translation) or were not correctly positioned, often due to Javascript errors. This fixes all major problems with the wizards. Remaining issues will be subject to at least one separate Jira.

Fixes: WEB-11

@steinwinde steinwinde changed the title Fix more relevant issues with the Configuration Wizard fix: more relevant issues with the Configuration Wizard Feb 16, 2025
@steinwinde steinwinde changed the title fix: more relevant issues with the Configuration Wizard fix: some issues with the Configuration Wizard Feb 16, 2025
Copy link
Collaborator

@PC-11-00 PC-11-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PC-11-00
Copy link
Collaborator

@steinwinde can we squash all the commits to one commit

@steinwinde steinwinde force-pushed the fix-issues-setup-product-config-wizard branch from e633985 to 9eb8719 Compare February 18, 2025 12:20
Correct labels in the context of the wizards, make no wizard terminates
prematurely, make modal windows appear well positioned.

Fixes: WEB-11
@steinwinde steinwinde force-pushed the fix-issues-setup-product-config-wizard branch from 9eb8719 to f6660f1 Compare February 18, 2025 12:34
@IOhacker IOhacker merged commit 30e895c into openMF:master Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants