-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11 implement osi validation check against a set of rules #12
11 implement osi validation check against a set of rules #12
Conversation
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
OSI-Validation is now running on both output trace files (TrafficUpdate and TrafficCommandUpdate). And for both trace files, two sets of rules are tested: The default rules from OSI and custom rules placed in rules/output_rules according to the defined output fields in the readme. This is the output in the pipeline: The first test with the default rules does not generate any warning, so everything is compliant with the OSI standard. The second test generates one warning per trace file:
The pipeline is currently not failing. I could check if the last line of the individual osi-validation output ends with "--------------" to detect, if there were no warnings and if not set the job to fail. What do you think @jdsika ? |
Signed-off-by: ClemensLinnhoff <[email protected]>
… in readme Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Pipeline now fails if errors are found in a trace file, as implemented in OpenSimulationInterface/osi-validation#76 |
- name: Checkout develop Branch | ||
if: steps.cache-osi-validation.outputs.cache-hit != 'true' | ||
working-directory: /tmp/osi-validation | ||
run: git checkout develop_traffic_participant_model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed to the main branch, once OpenSimulationInterface/osi-validation#76 and OpenSimulationInterface/osi-validation#74 are merged in osi-validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else is ready for review @jdsika.
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Reference to a related issue in the repository
#11, #14
Add a description
Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review