Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 implement osi validation check against a set of rules #12

Merged

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented May 28, 2024

Reference to a related issue in the repository
#11, #14

Add a description

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

@ClemensLinnhoff ClemensLinnhoff linked an issue May 28, 2024 that may be closed by this pull request
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Contributor Author

OSI-Validation is now running on both output trace files (TrafficUpdate and TrafficCommandUpdate).

And for both trace files, two sets of rules are tested: The default rules from OSI and custom rules placed in rules/output_rules according to the defined output fields in the readme. This is the output in the pipeline:
image

The first test with the default rules does not generate any warning, so everything is compliant with the OSI standard.

The second test generates one warning per trace file:

  1. The dismissed_action in the TrafficCommandUpdate is not set, which is correct, because it is only set, when an action is actually dismissed. I am currently not sure how to handle this. So the is_set rule needs to be removed from the rules but we still want to indicate, that this field is filled if necessary.
  2. BaseMoving.orientation is not set in the TrafficUpdate. This is actually a bug, that is correctly caught and should be fixed.

The pipeline is currently not failing. I could check if the last line of the individual osi-validation output ends with "--------------" to detect, if there were no warnings and if not set the job to fail.

What do you think @jdsika ?

Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Contributor Author

Pipeline now fails if errors are found in a trace file, as implemented in OpenSimulationInterface/osi-validation#76

- name: Checkout develop Branch
if: steps.cache-osi-validation.outputs.cache-hit != 'true'
working-directory: /tmp/osi-validation
run: git checkout develop_traffic_participant_model
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed to the main branch, once OpenSimulationInterface/osi-validation#76 and OpenSimulationInterface/osi-validation#74 are merged in osi-validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else is ready for review @jdsika.

@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review June 4, 2024 07:37
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika June 4, 2024 07:38
@ClemensLinnhoff ClemensLinnhoff merged commit d06687c into main Jun 13, 2024
20 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 11-implement-osi-validation-check-against-a-set-of-rules branch June 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Implement osi-validation check against a set of rules
2 participants