Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metrics to InfluxDB v2 python client #3167

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move metrics to InfluxDB v2 python client #3167

wants to merge 3 commits into from

Conversation

bnavigator
Copy link

Fixes #3034

@bnavigator bnavigator force-pushed the python-influxdb-client branch from b1b90fc to 5571a66 Compare September 26, 2024 13:30
@bnavigator bnavigator marked this pull request as ready for review September 29, 2024 17:52
dirkmueller
dirkmueller approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for working on this, this has been an eternal TODO that noone was brave enough for tackling.

I'll try to find some testing

dirkmueller
dirkmueller requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Couldn't run '/code/metrics.py' as Python code: SyntaxError: invalid syntax (metrics.py, line 370)

@bnavigator bnavigator force-pushed the python-influxdb-client branch from a060a6e to c4b3b78 Compare October 2, 2024 10:56
@bnavigator bnavigator requested a review from dirkmueller October 2, 2024 10:56
@dirkmueller
Copy link
Member

/cc @boombatower

@bnavigator
Copy link
Author

ModuleNotFoundError: No module named 'influxdb_client'

I haven't found yet another specification where the installation of influxdb-client is missing

@boombatower
Copy link

boombatower commented Oct 2, 2024 •
edited
Loading

Testing it is not easy. One need access to the right data and setup. Looks like some of the grafana updates messed up some of the graphs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller Awaiting requested review from dirkmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Influxdb 1 is EOL
3 participants
@bnavigator @dirkmueller @boombatower