Remove remote background from CSP example #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! Same issue with: Perhaps we should add an unsplash image for the example and add it to In which case we'd have: "organisationLogoUrl" => "/images/logo.png",
...
"backgroundImageUrl" => "/images/bg.jpg",What do you think? Happy to amend the PR to include this if so |
|
I'm unsure, the default gradient background is quite nice - but I get that you may want to indicate that a background image can be used. There are also a11y contrast errors with the footer text colour vs parts of images or the default gradient background, see: #23 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSP example settings has a remote background image