Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in README regarding tool responses #13

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

Jai0401
Copy link
Contributor

@Jai0401 Jai0401 commented Mar 11, 2025

"We process the tool calls (if any) and append the tool responses messsages."
→ "We process the tool calls (if any) and append the tool response messages." (typo: "messsages" → "messages")
"If the response has a final output (see below for the more on this), we return it and end the loop."
→ "If the response has a final output (see below for more on this), we return it and end the loop." (remove "the")

@notV3NOM
Copy link

Hi, the changes in your PR appears to duplicate the modifications already proposed in PR #4

@Jai0401
Copy link
Contributor Author

Jai0401 commented Mar 11, 2025

Hi @notV3NOM , PR #4 seems quite cluttered with duplicate or overlapping changes.

@Jai0401
Copy link
Contributor Author

Jai0401 commented Mar 11, 2025

Hi @rm-openai, could you please review my PR when you have a moment?

@rm-openai rm-openai merged commit c8f3cdd into openai:main Mar 12, 2025
5 checks passed
nakasy000 pushed a commit to nakasy000/openai-agents-python that referenced this pull request Mar 27, 2025
fix: correct typo in README regarding tool responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants