Remove redundant weaker tracing assertions #261
Merged
+4
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smile920423
added a commit
to smile920423/openai-agents-python
that referenced
this pull request
Mar 31, 2025
…r stronger tests (#288) Following openai/openai-agents-python#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #25, this removes uses of
fetch_tracesandfetch_ordered_spanswhere there's already a stronger assertion usingfetch_normalized_spans. This is to help move towards the stronger style as much as possible, since people are still adding weaker assertions such as this in #91. The next step will be to find remaining uses offetch_ordered_spansthat can be replaced.